feat(unified-share-modal): add custom avatars click handler #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjuanitas
previously approved these changes
Oct 1, 2024
Comment on lines
374
to
375
| /** A custom action to be invoked instead of default behavior when collaborators avatars are clicked */ | ||
| handleCollaboratorAvatarsClick?: () => void, |
There was a problem hiding this comment.
nit: this list of sorted alphabetically
There was a problem hiding this comment.
Nice catch, adjusted
| @@ -371,6 +371,8 @@ type BaseUnifiedShareProps = CollaboratorAvatarsTypes & | |||
|
|
|||
| // Prop types for the Unified Share Modal | |||
| export type USMProps = BaseUnifiedShareProps & { | |||
| /** A custom action to be invoked instead of default behavior when collaborators avatars are clicked */ | |||
| handleCollaboratorAvatarsClick?: () => void, | |||
There was a problem hiding this comment.
nit: for the prop names of callback functions, we usually use the "on" prefix. "handle" would be used instead when we're defining a function/method
e.g. onCollaboratorListClick
There was a problem hiding this comment.
Thanks for the suggestion, adjusted
tnastula
force-pushed
the
custom-avatars-click-handler
branch
from
83649c6
to
0be4f58
Compare
tnastula
force-pushed
the
custom-avatars-click-handler
branch
from
0be4f58
to
af4560e
Compare
tnastula
force-pushed
the
custom-avatars-click-handler
branch
from
af4560e
to
30e2f1a
Compare
|
@tjuanitas I don't know why Chromatic fails. Those are not my changes |
tjuanitas
approved these changes
Oct 1, 2024
tjiang-box
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a handler to USM that if defined will trigger alternate, custom action upon clicking avatars