feat(metadata-sidebar): disable delete button #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-in-a-box
requested changes
Sep 25, 2024
There was a problem hiding this comment.
we need to add unit tests for when the button is disabled under specific conditions and enabled under different conditions
There was a problem hiding this comment.
we can also add a storybook story to showcase that the button is disabled
There was a problem hiding this comment.
added both unit and storybook tests
karolinaru
force-pushed
the
disabled-delete-button
branch
2 times, most recently
from
01410b9
to
081b2af
Compare
jankowiakdawid
approved these changes
Sep 26, 2024
greg-in-a-box
approved these changes
Sep 26, 2024
jankowiakdawid
force-pushed
the
disabled-delete-button
branch
from
081b2af
to
35a9a98
Compare
JChan106
approved these changes
Sep 26, 2024
jankowiakdawid
pushed a commit
to jankowiakdawid/box-ui-elements
that referenced
this pull request
Sep 27, 2024
* feat(metadata-sidebar): disable delete button * feat(metadata-sidebar): remove console.log * feat(metadata-sidebar): unit tests * feat(metadata-sidebar): storybook tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request disables the Delete button in the MetadataInstanceEditor when a user starts creating a new template. Since there's nothing to delete before the instance is created, the button stays inactive.
Editing new template chosen from dropdown:
Editing already existing instance:
