feat(boxai-sidebar): Empty Sidebar for Box AI #3668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
80
to
95
| test('should not fetch the file data if the id has not changed', () => { | ||
| const wrapper = getWrapper({ fileId: '123' }); | ||
| const instance = wrapper.instance(); | ||
| const newProps = { fileId: '123' }; | ||
|
|
||
| instance.fetchFile = jest.fn(); | ||
| instance.setState({ view: 'activityFeed' }); | ||
| instance.setState = jest.fn(); | ||
|
|
||
| instance.componentDidUpdate(newProps); | ||
|
|
||
| expect(instance.fetchFile).not.toBeCalled(); | ||
| expect(instance.setState).not.toBeCalled(); | ||
| }); |
There was a problem hiding this comment.
Isn't that an exact copy of the above test?
There was a problem hiding this comment.
Unresolving this comment as I don't understand why do we need this duplicated test?
greg-in-a-box
requested changes
Sep 20, 2024
|
|
jankowiakdawid
previously approved these changes
Sep 24, 2024
DanilaRubleuski
force-pushed
the
box-ai-panel-preview-empty-sidebar
branch
from
5948f9b
to
002762c
Compare
DanilaRubleuski
dismissed
jankowiakdawid’s stale review
The base branch was changed.
DanilaRubleuski
force-pushed
the
box-ai-panel-preview-empty-sidebar
branch
from
002762c
to
7bfea1f
Compare
greg-in-a-box
requested changes
Sep 24, 2024
src/elements/content-sidebar/stories/tests/BoxAISidebar-visual.stories.tsx
Outdated
Show resolved
Hide resolved
greg-in-a-box
requested changes
Sep 25, 2024
|
@greg-in-a-box could you please take another look? |
DanilaRubleuski
force-pushed
the
box-ai-panel-preview-empty-sidebar
branch
from
a42990f
to
bc720b9
Compare
greg-in-a-box
requested changes
Oct 2, 2024
Comment on lines
80
to
95
| test('should not fetch the file data if the id has not changed', () => { | ||
| const wrapper = getWrapper({ fileId: '123' }); | ||
| const instance = wrapper.instance(); | ||
| const newProps = { fileId: '123' }; | ||
|
|
||
| instance.fetchFile = jest.fn(); | ||
| instance.setState({ view: 'activityFeed' }); | ||
| instance.setState = jest.fn(); | ||
|
|
||
| instance.componentDidUpdate(newProps); | ||
|
|
||
| expect(instance.fetchFile).not.toBeCalled(); | ||
| expect(instance.setState).not.toBeCalled(); | ||
| }); |
There was a problem hiding this comment.
Unresolving this comment as I don't understand why do we need this duplicated test?
kkuliczkowski-box
previously approved these changes
Oct 3, 2024
TylerGauntlett
approved these changes
Oct 3, 2024
greg-in-a-box
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now PR needs SidebarPanels.test.js to be fixed, to be reviewed fully
Description
Added empty sidebar for Box AI, so the next features could be added to this empty container in next PRs.
Screenshots