fix(hubs): fix shared link text #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix public shared link text for hubs
greg-in-a-box
approved these changes
Sep 16, 2024
davidkatko
reviewed
Sep 16, 2024
| @@ -291,11 +291,6 @@ const messages = defineMessages({ | |||
| description: 'Description of an open shared link', | |||
| id: 'boxui.unifiedShare.peopleWithLinkDescription', | |||
| }, | |||
| peopleWithLinkSignedInRequiredDescription: { | |||
There was a problem hiding this comment.
are we sure we/someone else won't need this in the future for any reason? since deleting the message deletes the translation; and i assume Box pays for each translation that needs to be generated
rosepierce
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix public shared link text for hubs