Fix: upload reachability test should accept empty preflight response (#…

…152)
box · Jan 12, 2018 · 5e7a39a · 5e7a39a
1 parent 7d0746d
commit 5e7a39a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/api/uploads/UploadReachability.js b/src/api/uploads/UploadReachability.js
@@ -125,13 +125,11 @@ class UploadsReachability {
      * @return {string}
      */
     handlePreflightResponse(response?: Object) {
-        if (!response) {
+        if (!response || !response.upload_url) {
             return DEFAULT_HOSTNAME_UPLOAD;
         }
 
-        const { upload_url } = response;
-
-        const splitUrl = upload_url.split('/');
+        const splitUrl = response.upload_url.split('/');
         return `${splitUrl[0]}//${splitUrl[2]}`;
     }
 }

diff --git a/src/api/uploads/__tests__/UploadsReachability-test.js b/src/api/uploads/__tests__/UploadsReachability-test.js
@@ -44,6 +44,7 @@ describe('api/UploadsReachability', () => {
     describe('handlePreflightResponse()', () => {
         withData(
             [
+                [{random: 1}, DEFAULT_HOSTNAME_UPLOAD],
                 [undefined, DEFAULT_HOSTNAME_UPLOAD],
                 [null, DEFAULT_HOSTNAME_UPLOAD],
                 [{ upload_url: 'http://random.com/hello123' }, 'http://random.com']