Chore: track encoding type for documents #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @JustinHoldstock has signed the CLA. Thanks for the pull request! |
jstoffan
previously approved these changes
Feb 4, 2019
jstoffan
reviewed
Feb 4, 2019
jstoffan
previously approved these changes
Feb 4, 2019
Yup, just wanted to make sure this was fine, first |
JustinHoldstock
requested review from
jeremypress,
pramodsum,
priyajeet,
ConradJChan and
DanDeMicco
ConradJChan
previously approved these changes
Feb 4, 2019
src/lib/Preview.js
Outdated
| @@ -1524,7 +1524,7 @@ class Preview extends EventEmitter { | |||
| * @private | |||
| * @return {void} | |||
| */ | |||
| emitLoadMetrics() { | |||
| emitLoadMetrics({ encoding }) { | |||
There was a problem hiding this comment.
It feels a little strange IMO to pass in an empty object to emitLoadMetrics to avoid an error destructuring encoding from the argument. Would it make sense to instead have logic to handle an undefined argument?
oh and jsdoc for the new method argument.
There was a problem hiding this comment.
I can also just default the params list via { encoding } = {}
added 2 commits
February 5, 2019 10:18
…ck/box-content-preview into add-encoding-to-load-event
ConradJChan
approved these changes
Feb 5, 2019
jstoffan
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.