Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Better error message for file of unknown type #862

Merged
merged 4 commits into from
Nov 16, 2018
Merged

Fix: Better error message for file of unknown type #862

merged 4 commits into from
Nov 16, 2018

Conversation

jeremypress
Copy link
Contributor

No description provided.

@boxcla
Copy link

boxcla commented Nov 13, 2018

Verified that @jeremypress has signed the CLA. Thanks for the pull request!

DanDeMicco
DanDeMicco approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@DanDeMicco DanDeMicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but as discussed I dont think the file extension in the error message helps and we can just use the new one you added

@jeremypress jeremypress merged commit de1246a into box:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanDeMicco DanDeMicco DanDeMicco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremypress @boxcla @DanDeMicco