Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remote-sync): Enable remote syncing based on an API response #1506

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

TylerGauntlett
Copy link
Contributor

Why?

The current rsync.json file only supports a statically defined location. This works find for statically defined host/IP addresses but doesn't work well if the remote source goes through another proxy layer (ie K8 ingress, reverse proxy, etc)

How?

To resolve this, I added the ability to define a host/IP address from the result of an API call. This expands on the current rsync.json file while preserving backwards compatablity.

Example

{
    "apiLocation": {
        "url": "https://example-website/api/info",
        "user": "root",
        "ip": "serverIpAddress",
        "path": "/var/www/assets/example-website"
    }
}

@TylerGauntlett TylerGauntlett requested a review from a team as a code owner September 21, 2023 00:57
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Tyler Gauntlett seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bfoxx1906 bfoxx1906 merged commit 11cfaa7 into box:master Sep 21, 2023
2 of 3 checks passed
@TylerGauntlett TylerGauntlett deleted the enable-api-sync branch September 21, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants