Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controls): Add react versions of existing media control icons #1301

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

jstoffan
Copy link
Collaborator

@jstoffan jstoffan commented Dec 3, 2020

No description provided.

@jstoffan jstoffan requested a review from a team as a code owner December 3, 2020 00:48
function IconVolumeLow24(props: React.SVGProps<SVGSVGElement>): JSX.Element {
return (
<svg focusable={false} height={24} viewBox="-3 5 24 24" width={24} {...props}>
<path d="M0 14v6h4l5 5V9l-5 5H0z" fill="#FFF" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these #fff and #FFF be consistent?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other icons are already inconsistent. I can do this separately if it's important?

Copy link
Contributor

@cweeii cweeii Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using the buie $white color?


function IconVolumeLow24(props: React.SVGProps<SVGSVGElement>): JSX.Element {
return (
<svg focusable={false} height={24} viewBox="-3 5 24 24" width={24} {...props}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these negative values in the viewBox worrisome?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVGs are copied directly from the existing icons. I'd rather not mess with them much.

@mergify mergify bot merged commit 3fc73a8 into box:master Dec 3, 2020
@jstoffan jstoffan deleted the react-ui-icons-2 branch December 3, 2020 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants