Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pdf): Update pdf.js to v2.2.228 and closure compiler to v20190729 #1048

Merged
merged 2 commits into from
Aug 20, 2019
Merged

feat(pdf): Update pdf.js to v2.2.228 and closure compiler to v20190729 #1048

merged 2 commits into from
Aug 20, 2019

Conversation

jstoffan
Copy link
Collaborator

@jstoffan jstoffan commented Aug 7, 2019 •
edited
Loading

Summary
This changeset is partially based on and supersedes #810 and #908. I've migrated our calls to pdf.js to match the associated API changes in the latest version. However, there is no official migration guide, so further manual testing on document variations will be required.

Known Issues

  • Trivial: Resizing the browser causes a harmless TextLayer task cancelled console error
  • Blocker: Find controls do not work properly and do not highlight search results

Features Tested

  • Annotations
  • Find controls and keyboard shortcuts
  • Documents with digital signatures
  • Documents with single and multiple pages
  • Presentations with single and multiple pages
  • Fullscreen mode via on-screen controls
  • Page-up/down via on-screen controls and scroll wheel
  • Text layer highlighting via click-drag and double-click
  • Zoom-in/out via on-screen controls
  • Thumbnail sidebar

@boxcla
Copy link

boxcla commented Aug 7, 2019

Verified that @jstoffan has signed the CLA. Thanks for the pull request!

@jstoffan jstoffan force-pushed the pdfjs2 branch 5 times, most recently from 6c94965 to 0942acd Compare August 14, 2019 00:32
@jstoffan jstoffan marked this pull request as ready for review August 14, 2019 00:54
@jstoffan jstoffan requested a review from a team as a code owner August 14, 2019 00:54
mickr
mickr previously approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@mickr mickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't have enough context for the specific changes but code looks good.

src/lib/viewers/doc/SinglePageViewer.js Outdated Show resolved Hide resolved
@jstoffan jstoffan force-pushed the pdfjs2 branch 2 times, most recently from 2e2581f to 5375f96 Compare August 16, 2019 00:31
@mergify mergify bot merged commit 44cd681 into box:master Aug 20, 2019
@jstoffan jstoffan deleted the pdfjs2 branch March 4, 2020 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickr mickr mickr approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jstoffan @boxcla @mickr