Fix: Additional logic to reset highlight-comment threads (#386)

box · Sep 13, 2017 · faef3df · faef3df
1 parent 7bc9412
commit faef3df
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/lib/annotations/doc/DocHighlightThread.js b/src/lib/annotations/doc/DocHighlightThread.js
@@ -47,6 +47,8 @@ class DocHighlightThread extends AnnotationThread {
             this.type = TYPES.highlight;
         } else if (!this.isMobile) {
             this.destroy();
+        } else {
+            this.reset();
         }
     }
 

diff --git a/src/lib/annotations/doc/__tests__/DocHighlightThread-test.js b/src/lib/annotations/doc/__tests__/DocHighlightThread-test.js
@@ -77,6 +77,16 @@ describe('lib/annotations/doc/DocHighlightThread', () => {
             expect(highlightThread.destroy).to.be.called;
             assert.equal(highlightThread.element, null);
         });
+
+        it('should reset the thread if on mobile and a comment-highlight', () => {
+            sandbox.stub(highlightThread, 'reset');
+            highlightThread.annotations = [{}, {}, {}];
+            highlightThread.isMobile = true;
+
+            highlightThread.cancelFirstComment();
+
+            expect(highlightThread.reset).to.be.called;
+        });
     });
 
     describe('destroy()', () => {