From 979a912fa534f0cecde7cba7f1b96410e4b83dcf Mon Sep 17 00:00:00 2001 From: Conrad Chan Date: Thu, 4 Apr 2019 13:00:08 -0700 Subject: [PATCH] Update: emit thumbnailsOpen in DocBaseViewer (#977) --- src/lib/events.js | 4 +++- src/lib/viewers/doc/DocBaseViewer.js | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/lib/events.js b/src/lib/events.js index b4ab68469..04b158a47 100644 --- a/src/lib/events.js +++ b/src/lib/events.js @@ -10,7 +10,9 @@ export const VIEWER_EVENT = { mediaEndAutoplay: 'mediaendautoplay', // Media playback has completed, with autoplay enabled. error: 'error', // When an error occurs. default: 'viewerevent', // The default viewer event. - metric: 'viewermetric' // A viewer metric. + metric: 'viewermetric', // A viewer metric. + thumbnailsClose: 'thumbnailsClose', // When thumbnails sidebar closes + thumbnailsOpen: 'thumbnailsOpen' // When thumbnails sidebar opens }; // Error codes logged by preview with "preview_error" events diff --git a/src/lib/viewers/doc/DocBaseViewer.js b/src/lib/viewers/doc/DocBaseViewer.js index e82f3d5bc..adc0a1f4f 100644 --- a/src/lib/viewers/doc/DocBaseViewer.js +++ b/src/lib/viewers/doc/DocBaseViewer.js @@ -143,6 +143,7 @@ class DocBaseViewer extends BaseViewer { if (this.shouldThumbnailsBeToggled()) { this.rootEl.classList.add(CLASS_BOX_PREVIEW_THUMBNAILS_OPEN); + this.emit(VIEWER_EVENT.thumbnailsOpen); } } } @@ -1363,13 +1364,13 @@ class DocBaseViewer extends BaseViewer { this.rootEl.classList.add(CLASS_BOX_PREVIEW_THUMBNAILS_CLOSE); this.rootEl.classList.add(CLASS_BOX_PREVIEW_THUMBNAILS_CLOSE_ACTIVE); metricName = USER_DOCUMENT_THUMBNAIL_EVENTS.CLOSE; - eventName = 'thumbnailsClose'; + eventName = VIEWER_EVENT.thumbnailsClose; } else { this.rootEl.classList.remove(CLASS_BOX_PREVIEW_THUMBNAILS_CLOSE); this.rootEl.classList.add(CLASS_BOX_PREVIEW_THUMBNAILS_OPEN); this.rootEl.classList.add(CLASS_BOX_PREVIEW_THUMBNAILS_OPEN_ACTIVE); metricName = USER_DOCUMENT_THUMBNAIL_EVENTS.OPEN; - eventName = 'thumbnailsOpen'; + eventName = VIEWER_EVENT.thumbnailsOpen; } this.emitMetric({ name: metricName, data: pagesCount });