Fix: Setting innerHTML in annotatorUtil.generateButton() (#446)

box · Oct 19, 2017 · 4035d8e · 4035d8e
1 parent 9f06212
commit 4035d8e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/lib/annotations/__tests__/annotatorUtil-test.js b/src/lib/annotations/__tests__/annotatorUtil-test.js
@@ -236,12 +236,12 @@ describe('lib/annotations/annotatorUtil', () => {
 
     describe('generateBtn()', () => {
         it('should return button node from specified details', () => {
-            const btn = generateBtn('class', 'title', 'content', 'type');
+            const btn = generateBtn('class', 'title', document.createElement('div'), 'type');
             expect(btn).to.have.class('bp-btn-plain');
             expect(btn).to.have.class('class');
             expect(btn).to.have.attribute('data-type', 'type');
             expect(btn).to.have.attribute('title', 'title');
-            expect(btn).to.have.text('content');
+            expect(btn).to.contain.html(document.createElement('div'));
         });
     });
 

diff --git a/src/lib/annotations/annotatorUtil.js b/src/lib/annotations/annotatorUtil.js
@@ -286,7 +286,7 @@ export function generateBtn(className, title, content, dataType = '') {
     buttonEl.classList.add(CLASS_BUTTON);
     buttonEl.classList.add(className);
     buttonEl.title = title;
-    buttonEl.textContent = content;
+    buttonEl.innerHTML = content;
     buttonEl.setAttribute('data-type', dataType);
     return buttonEl;
 }