Fix: Remove unhandled errors from unit tests (#498)

box · Nov 22, 2017 · 2e71743 · 2e71743
1 parent 6d61b9d
commit 2e71743
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 17 deletions.
diff --git a/src/lib/viewers/box3d/image360/__tests__/Image360Renderer-test.js b/src/lib/viewers/box3d/image360/__tests__/Image360Renderer-test.js
@@ -238,10 +238,6 @@ describe('lib/viewers/box3d/image360/Image360Renderer', () => {
         });
     });
 
-    describe('loadPanoramaFile()', () => {
-        it('should have @jholdstock implement this test after @mbond gets 3D image representations in prod');
-    });
-
     describe('enableVr()', () => {
         beforeEach(() => {
             // We don't care about super calls :D

diff --git a/src/lib/viewers/doc/__tests__/DocBaseViewer-test.js b/src/lib/viewers/doc/__tests__/DocBaseViewer-test.js
@@ -749,12 +749,12 @@ describe('src/lib/viewers/doc/DocBaseViewer', () => {
             docBase.isMobile = false;
             sandbox.stub(PDFJS, 'getDocument').returns(Promise.resolve({}));
 
-            docBase.initViewer('');
-
-            expect(stubs.pdfViewerStub).to.be.calledWith({
-                container: sinon.match.any,
-                linkService: sinon.match.any,
-                enhanceTextSelection: true
+            return docBase.initViewer('').then(() => {
+                expect(stubs.pdfViewerStub).to.be.calledWith({
+                    container: sinon.match.any,
+                    linkService: sinon.match.any,
+                    enhanceTextSelection: true
+                });
             });
         });
 
@@ -765,12 +765,12 @@ describe('src/lib/viewers/doc/DocBaseViewer', () => {
             docBase.isMobile = true;
             sandbox.stub(PDFJS, 'getDocument').returns(Promise.resolve({}));
 
-            docBase.initViewer('');
-
-            expect(stubs.pdfViewerStub).to.be.calledWith({
-                container: sinon.match.any,
-                linkService: sinon.match.any,
-                enhanceTextSelection: false
+            return docBase.initViewer('').then(() => {
+                expect(stubs.pdfViewerStub).to.be.calledWith({
+                    container: sinon.match.any,
+                    linkService: sinon.match.any,
+                    enhanceTextSelection: false
+                });
             });
         });
 

diff --git a/src/lib/viewers/media/__tests__/MediaBaseViewer-test.js b/src/lib/viewers/media/__tests__/MediaBaseViewer-test.js
@@ -179,8 +179,9 @@ describe('lib/viewers/media/MediaBaseViewer', () => {
     describe('errorHandler', () => {
         it('should emit the error and set a display message', () => {
             sandbox.stub(media, 'emit');
-
             const err = new Error('blah');
+            sandbox.mock(window.console).expects('error').withArgs(err);
+
             media.errorHandler(err);
 
             err.displayMessage = 'We\'re sorry, the preview didn\'t load. Please refresh the page.';