Chore: Add util tests and fix file tests (#709)

- Move hostname check to Browser function so we can test `isBoxWebApp()`
- Fix incorrect `file.canDownload()` tests, they were missing brackets
- Add missing peer dependency
- Clean up package.json and run `yarn upgrade`

package.json

@@ -75,6 +75,7 @@
     "optimize-css-assets-webpack-plugin": "^3.2.0",
     "phantomjs-prebuilt": "^2.1.16",
     "postcss-loader": "^2.0.9",
+    "postcss-sass": "^0.3.0",
     "prettier": "^1.8.2",
     "prettier-eslint-cli": "^4.4.2",
     "raw-loader": "^0.5.1",
@@ -130,6 +131,5 @@
       "prettier-eslint --print-width 120 --single-quote --tab-width 4 --write",
       "git add"
     ]
-  },
-  "dependencies": {}
+  }
 }

src/lib/Location.js

@@ -0,0 +1,21 @@
+class Location {
+    /**
+     * Returns window hostname to simplify testing.
+     *
+     * @return {string} Window hostname
+     */
+    static getHostname() {
+        return window.location.hostname || '';
+    }
+
+    /**
+     * Returns window origin to simplify testing.
+     *
+     * @return {string} Window location
+     */
+    static getOrigin() {
+        return window.location.origin || '';
+    }
+}
+
+export default Location;

src/lib/__tests__/file-test.js

@@ -376,7 +376,7 @@ describe('lib/file', () => {
             [false, true, false, false, false],
             [true, false, false, false, false],
             [true, true, true, true, true],
-        ].forEach((isDownloadable, isDownloadEnabled, havePermission, isBrowserSupported, expectedResult) => {
+        ].forEach(([isDownloadable, isDownloadEnabled, havePermission, isBrowserSupported, expectedResult]) => {
             it('should only return true if all of: file is downloadable, download is enabled, user has permissions, and browser can download is true', () => {
                 file.permissions.can_download = havePermission;
                 file.is_download_available = isDownloadable

src/lib/__tests__/util-test.js

@@ -1,6 +1,7 @@
 /* eslint-disable no-unused-expressions */
 import 'whatwg-fetch';
 import fetchMock from 'fetch-mock';
+import Location from '../Location';
 import * as util from '../util';
 
 const sandbox = sinon.sandbox.create();
@@ -835,8 +836,19 @@ describe('lib/util', () => {
     });
 
     describe('isBoxWebApp()', () => {
-        it('should return false when window location is not a Box domain', () => {
-            expect(util.isBoxWebApp()).to.be.false;
-        });
+            [
+            ['https://test.app.box.com', true],
+            ['https://foo.ent.box.com', true],
+            ['https://bar.app.boxcn.net', true],
+            ['https://baz.ent.boxenterprise.net', true],
+            ['https://haha.box.net', false],
+            ['https://some.other.domain', false]
+        ]
+        .forEach(([hostname, expectedResult]) => {
+            it('should return true when window location is a Box domain', () => {
+                sandbox.stub(Location, 'getHostname').returns(hostname);
+                expect(util.isBoxWebApp()).to.equal(expectedResult);
+            });
+        })
     });
 });

src/lib/util.js

@@ -1,6 +1,7 @@
 import Uri from 'jsuri';
 import 'whatwg-fetch';
 
+import Location from './Location';
 import { isDownloadHostBlocked, replaceDownloadHostWithDefault } from './downloadReachability';
 
 const HEADER_CLIENT_NAME = 'X-Box-Client-Name';
@@ -901,5 +902,6 @@ export function isValidFileId(fileId) {
  * @return {boolean} Is Preview running in the Box WebApp
  */
 export function isBoxWebApp() {
-    return (window.location.hostname || '').indexOf('app.box.com') !== -1;
+    const boxHostnameRegex = /(app|ent)\.(box\.com|boxcn\.net|boxenterprise\.net)/;
+    return boxHostnameRegex.test(Location.getHostname());
 }

src/lib/viewers/office/OfficeViewer.js

@@ -1,5 +1,6 @@
 import BaseViewer from '../BaseViewer';
 import Browser from '../../Browser';
+import Location from '../../Location';
 import Popup from '../../Popup';
 import { CLASS_HIDDEN } from '../../constants';
 import { getRepresentation } from '../../file';
@@ -179,7 +180,7 @@ class OfficeViewer extends BaseViewer {
             formEl.submit();
 
             // Tell Office Online that we are ready to receive messages
-            iframeEl.contentWindow.postMessage(MESSAGE_HOST_READY, window.location.origin);
+            iframeEl.contentWindow.postMessage(MESSAGE_HOST_READY, Location.getOrigin());
         } else {
             iframeEl.src = this.setupRunmodeURL(appHost, file.id, sharedLink);
         }
@@ -280,7 +281,7 @@ class OfficeViewer extends BaseViewer {
     createFormElement(apiHost, fileId, sharedLink, locale) {
         // Setting the action URL
         const WOPISrc = this.setupWOPISrc(apiHost, fileId, sharedLink);
-        const origin = { origin: window.location.origin };
+        const origin = { origin: Location.getOrigin() };
         const formEl = this.containerEl.appendChild(document.createElement('form'));
         // We pass our origin in the sessionContext so that Microsoft will pass
         // this to the checkFileInfo endpoint. From their we can set it as the

src/lib/viewers/office/__tests__/OfficeViewer-test.js

@@ -1,6 +1,7 @@
 /* eslint-disable no-unused-expressions */
 import BaseViewer from '../../BaseViewer';
 import Browser from '../../../Browser';
+import Location from '../../../Location';
 import OfficeViewer from '../OfficeViewer';
 import * as util from '../../../util';
 import { CLASS_HIDDEN } from '../../../constants';
@@ -283,8 +284,10 @@ describe('lib/viewers/office/OfficeViewer', () => {
 
     describe('createFormElement()', () => {
         beforeEach(() => {
+            const origin = 'someOrigin';
+            sandbox.stub(Location, 'getOrigin').returns(origin);
             stubs.setupWOPISrc = sandbox.stub(office, 'setupWOPISrc').returns('src');
-            stubs.sessionContext = JSON.stringify({ origin: window.location.origin });
+            stubs.sessionContext = JSON.stringify({ origin });
             stubs.formEl = office.createFormElement(
                 office.options.apiHost,
                 office.options.file.id,