From 7a0e39369b5971be3036e0678455ec82bcb5e321 Mon Sep 17 00:00:00 2001 From: Chancellor Clark Date: Wed, 1 May 2024 10:53:45 -0400 Subject: [PATCH] feat: respect logger=false in environment variables (#838) --- .changeset/rude-dodos-collect.md | 5 +++++ apps/core/client/index.ts | 4 +++- apps/core/lib/kv/index.ts | 4 +++- 3 files changed, 11 insertions(+), 2 deletions(-) create mode 100644 .changeset/rude-dodos-collect.md diff --git a/.changeset/rude-dodos-collect.md b/.changeset/rude-dodos-collect.md new file mode 100644 index 000000000..2de245db5 --- /dev/null +++ b/.changeset/rude-dodos-collect.md @@ -0,0 +1,5 @@ +--- +"@bigcommerce/catalyst-core": patch +--- + +Respects when `CLIENT_LOGGER="false"` or `KV_LOGGER="false"` is set in .env.local regardless of environment. diff --git a/apps/core/client/index.ts b/apps/core/client/index.ts index f654ed24f..1aaf6e8a0 100644 --- a/apps/core/client/index.ts +++ b/apps/core/client/index.ts @@ -8,5 +8,7 @@ export const client = createClient({ storeHash: process.env.BIGCOMMERCE_STORE_HASH ?? '', channelId: process.env.BIGCOMMERCE_CHANNEL_ID, backendUserAgentExtensions: backendUserAgent, - logger: process.env.NODE_ENV !== 'production' || process.env.CLIENT_LOGGER === 'true', + logger: + (process.env.NODE_ENV !== 'production' && process.env.CLIENT_LOGGER !== 'false') || + process.env.CLIENT_LOGGER === 'true', }); diff --git a/apps/core/lib/kv/index.ts b/apps/core/lib/kv/index.ts index 9cfdb8c2b..0f73b1cac 100644 --- a/apps/core/lib/kv/index.ts +++ b/apps/core/lib/kv/index.ts @@ -83,7 +83,9 @@ async function createKVAdapter() { } const adapterInstance = new KV(createKVAdapter, { - logger: process.env.NODE_ENV !== 'production' || process.env.KV_LOGGER === 'true', + logger: + (process.env.NODE_ENV !== 'production' && process.env.KV_LOGGER !== 'false') || + process.env.KV_LOGGER === 'true', }); export { adapterInstance as kv };