From 6531bb2ee9b6a6125cd4f9f0e624e023897387be Mon Sep 17 00:00:00 2001 From: Jorge Moya Date: Tue, 27 Aug 2024 14:53:40 -0500 Subject: [PATCH] feat(core): remove quick add button from PLP (#1313) * feat(core): remove quick add button from PLP * fix: update tests --- .changeset/young-gorillas-hang.md | 5 + core/app/[locale]/(default)/layout.tsx | 17 +- .../product/[slug]/_components/details.tsx | 4 +- .../product-form/_actions/add-to-cart.ts | 0 .../fields/checkbox-field/fragment.ts | 0 .../fields/checkbox-field/index.tsx | 0 .../fields/date-field/fragment.ts | 0 .../product-form/fields/date-field/index.tsx | 0 .../fields/multi-line-text-field/fragment.ts | 0 .../fields/multi-line-text-field/index.tsx | 0 .../fields/multiple-choice-field/fragment.ts | 0 .../fields/multiple-choice-field/index.tsx | 0 .../fields/number-field/fragment.ts | 0 .../fields/number-field/index.tsx | 0 .../product-form/fields/quantity-field.tsx | 0 .../fields/shared/error-message.tsx | 0 .../fields/text-field/fragment.ts | 0 .../product-form/fields/text-field/index.tsx | 0 .../_components}/product-form/fragment.ts | 3 +- .../_components}/product-form/index.tsx | 7 +- .../product-form/use-product-form.ts | 0 core/app/api/product/[id]/route.ts | 63 ------ core/client/fragments/product-item.ts | 2 +- .../form}/_actions/add-to-cart.ts | 0 .../product-card/add-to-cart/form/index.tsx | 72 ++++++ .../product-card/add-to-cart/fragment.ts | 1 + .../product-card/add-to-cart/index.tsx | 78 +------ core/components/product-sheet/fragment.ts | 28 --- core/components/product-sheet/index.tsx | 49 ----- .../product-sheet/product-sheet-content.tsx | 207 ------------------ core/messages/en.json | 2 +- core/tests/routes.ts | 2 - .../core/components/radio-group.spec.ts | 29 ++- .../ui/desktop/core/components/swatch.spec.ts | 29 ++- .../components/counter.spec.ts | 2 +- ...ounter-default-1-tests-chromium-darwin.png | Bin 507 -> 426 bytes .../components/datepicker.spec.ts | 4 +- .../Date-picker-1-tests-chromium-darwin.png | Bin 2511 -> 2506 bytes .../components/radio-group.spec.ts | 4 +- ...lt-radio-group-1-tests-chromium-darwin.png | Bin 2263 -> 2484 bytes ...group-selected-1-tests-chromium-darwin.png | Bin 2462 -> 2643 bytes .../components/sheet.spec.ts | 18 -- .../Sheet-basic-1-tests-chromium-darwin.png | Bin 41739 -> 0 bytes 43 files changed, 134 insertions(+), 492 deletions(-) create mode 100644 .changeset/young-gorillas-hang.md rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/_actions/add-to-cart.ts (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fields/checkbox-field/fragment.ts (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fields/checkbox-field/index.tsx (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fields/date-field/fragment.ts (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fields/date-field/index.tsx (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fields/multi-line-text-field/fragment.ts (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fields/multi-line-text-field/index.tsx (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fields/multiple-choice-field/fragment.ts (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fields/multiple-choice-field/index.tsx (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fields/number-field/fragment.ts (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fields/number-field/index.tsx (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fields/quantity-field.tsx (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fields/shared/error-message.tsx (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fields/text-field/fragment.ts (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fields/text-field/index.tsx (100%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/fragment.ts (94%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/index.tsx (97%) rename core/{components => app/[locale]/(default)/product/[slug]/_components}/product-form/use-product-form.ts (100%) delete mode 100644 core/app/api/product/[id]/route.ts rename core/components/product-card/{ => add-to-cart/form}/_actions/add-to-cart.ts (100%) create mode 100644 core/components/product-card/add-to-cart/form/index.tsx delete mode 100644 core/components/product-sheet/fragment.ts delete mode 100644 core/components/product-sheet/index.tsx delete mode 100644 core/components/product-sheet/product-sheet-content.tsx delete mode 100644 core/tests/visual-regression/components/sheet.spec.ts delete mode 100644 core/tests/visual-regression/components/sheet.spec.ts-snapshots/Sheet-basic-1-tests-chromium-darwin.png diff --git a/.changeset/young-gorillas-hang.md b/.changeset/young-gorillas-hang.md new file mode 100644 index 000000000..4585f6261 --- /dev/null +++ b/.changeset/young-gorillas-hang.md @@ -0,0 +1,5 @@ +--- +"@bigcommerce/catalyst-core": patch +--- + +Remove "Quick add" button in PLP for products that have options. Will now just show a button that links to the product. diff --git a/core/app/[locale]/(default)/layout.tsx b/core/app/[locale]/(default)/layout.tsx index 424a833ad..fbd2d3b83 100644 --- a/core/app/[locale]/(default)/layout.tsx +++ b/core/app/[locale]/(default)/layout.tsx @@ -1,6 +1,5 @@ -import { NextIntlClientProvider } from 'next-intl'; -import { getMessages, unstable_setRequestLocale } from 'next-intl/server'; -import { PropsWithChildren, Suspense } from 'react'; +import { unstable_setRequestLocale } from 'next-intl/server'; +import { PropsWithChildren } from 'react'; import { getSessionCustomerId } from '~/auth'; import { client } from '~/client'; @@ -11,7 +10,6 @@ import { FooterFragment } from '~/components/footer/fragment'; import { Header } from '~/components/header'; import { Cart } from '~/components/header/cart'; import { HeaderFragment } from '~/components/header/fragment'; -import { ProductSheet } from '~/components/product-sheet'; import { LocaleType } from '~/i18n'; interface Props extends PropsWithChildren { @@ -40,8 +38,6 @@ export default async function DefaultLayout({ children, params: { locale } }: Pr fetchOptions: customerId ? { cache: 'no-store' } : { next: { revalidate } }, }); - const messages = await getMessages({ locale }); - return ( <>
} data={data.site} /> @@ -50,15 +46,6 @@ export default async function DefaultLayout({ children, params: { locale } }: Pr {children} - - - - - -