From 6a0fd31a30048f44594ac72efd93ef095f89d043 Mon Sep 17 00:00:00 2001 From: Elabajaba Date: Wed, 22 Mar 2023 16:01:23 -0400 Subject: [PATCH] rebase fixes for #8109 and #8079 --- .../src/contrast_adaptive_sharpening/mod.rs | 18 ++---------------- .../src/contrast_adaptive_sharpening/node.rs | 10 ++-------- examples/3d/fxaa.rs | 2 +- 3 files changed, 5 insertions(+), 25 deletions(-) diff --git a/crates/bevy_core_pipeline/src/contrast_adaptive_sharpening/mod.rs b/crates/bevy_core_pipeline/src/contrast_adaptive_sharpening/mod.rs index d7247acc03e91..2fa3676c063b1 100644 --- a/crates/bevy_core_pipeline/src/contrast_adaptive_sharpening/mod.rs +++ b/crates/bevy_core_pipeline/src/contrast_adaptive_sharpening/mod.rs @@ -11,7 +11,7 @@ use bevy_render::{ renderer::RenderDevice, texture::BevyDefault, view::{ExtractedView, ViewTarget}, - RenderApp, RenderSet, + Render, RenderApp, RenderSet, }; mod node; @@ -105,7 +105,7 @@ impl Plugin for CASPlugin { render_app .init_resource::() .init_resource::>() - .add_system(prepare_cas_pipelines.in_set(RenderSet::Prepare)); + .add_systems(Render, prepare_cas_pipelines.in_set(RenderSet::Prepare)); { let cas_node = CASNode::new(&mut render_app.world); let mut binding = render_app.world.resource_mut::(); @@ -113,13 +113,6 @@ impl Plugin for CASPlugin { graph.add_node(core_3d::graph::node::CONTRAST_ADAPTIVE_SHARPENING, cas_node); - graph.add_slot_edge( - graph.input_node().id, - core_3d::graph::input::VIEW_ENTITY, - core_3d::graph::node::CONTRAST_ADAPTIVE_SHARPENING, - CASNode::IN_VIEW, - ); - graph.add_node_edge( core_3d::graph::node::FXAA, core_3d::graph::node::CONTRAST_ADAPTIVE_SHARPENING, @@ -136,13 +129,6 @@ impl Plugin for CASPlugin { graph.add_node(core_2d::graph::node::CONTRAST_ADAPTIVE_SHARPENING, cas_node); - graph.add_slot_edge( - graph.input_node().id, - core_2d::graph::input::VIEW_ENTITY, - core_2d::graph::node::CONTRAST_ADAPTIVE_SHARPENING, - CASNode::IN_VIEW, - ); - graph.add_node_edge( core_2d::graph::node::FXAA, core_2d::graph::node::CONTRAST_ADAPTIVE_SHARPENING, diff --git a/crates/bevy_core_pipeline/src/contrast_adaptive_sharpening/node.rs b/crates/bevy_core_pipeline/src/contrast_adaptive_sharpening/node.rs index 04a9198c61c01..7a459cfee2299 100644 --- a/crates/bevy_core_pipeline/src/contrast_adaptive_sharpening/node.rs +++ b/crates/bevy_core_pipeline/src/contrast_adaptive_sharpening/node.rs @@ -5,7 +5,7 @@ use bevy_ecs::prelude::*; use bevy_ecs::query::QueryState; use bevy_render::{ extract_component::{ComponentUniforms, DynamicUniformIndex}, - render_graph::{Node, NodeRunError, RenderGraphContext, SlotInfo, SlotType}, + render_graph::{Node, NodeRunError, RenderGraphContext}, render_resource::{ BindGroup, BindGroupDescriptor, BindGroupEntry, BindingResource, BufferId, Operations, PipelineCache, RenderPassColorAttachment, RenderPassDescriptor, TextureViewId, @@ -29,8 +29,6 @@ pub struct CASNode { } impl CASNode { - pub const IN_VIEW: &'static str = "view"; - pub fn new(world: &mut World) -> Self { Self { query: QueryState::new(world), @@ -40,10 +38,6 @@ impl CASNode { } impl Node for CASNode { - fn input(&self) -> Vec { - vec![SlotInfo::new(CASNode::IN_VIEW, SlotType::Entity)] - } - fn update(&mut self, world: &mut World) { self.query.update_archetypes(world); } @@ -54,7 +48,7 @@ impl Node for CASNode { render_context: &mut RenderContext, world: &World, ) -> Result<(), NodeRunError> { - let view_entity = graph.get_input_entity(Self::IN_VIEW)?; + let view_entity = graph.view_entity(); let pipeline_cache = world.resource::(); let sharpening_pipeline = world.resource::(); let uniforms = world.resource::>(); diff --git a/examples/3d/fxaa.rs b/examples/3d/fxaa.rs index 6719f74039dfd..4a193228b77fe 100644 --- a/examples/3d/fxaa.rs +++ b/examples/3d/fxaa.rs @@ -21,7 +21,7 @@ fn main() { .insert_resource(Msaa::Off) .add_plugins(DefaultPlugins) .add_systems(Startup, setup) - .add_systems(Update, toggle_fxaa) + .add_systems(Update, (toggle_fxaa, toggle_sharpening)) .run(); }