Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor issues #696

Closed
Yuan-Mao opened this issue Apr 4, 2023 · 2 comments
Closed

Some minor issues #696

Yuan-Mao opened this issue Apr 4, 2023 · 2 comments

Comments

@Yuan-Mao
Copy link

Yuan-Mao commented Apr 4, 2023

The following lines might need some attention:

  1. https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/v/bsg_manycore_pod_mesh_array.v#L106
    Although it might actually be compatible, but global_x_li (and also global_y_li) has different dimension than the one declared in bsg_manycore_pod_mesh_row.v:
    https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/v/bsg_manycore_pod_mesh_row.v#L83

  2. https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/v/bsg_manycore_tile_compute_array_mesh.v#L117
    Should use subarray_num_tiles_[xy]p instead of num_tiles[xy]_p.

@taylor-bsg
Copy link
Contributor

@tommydcjung is this resolved

@tommydcjung
Copy link
Contributor

1 is not a bug.
2 is fixed here: #728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants