-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debian 10 (Buster) version of Flatpak silently fails to install app with spaces in name #804
Comments
This isn't the first time we've had problems caused by spaces in paths, and I'm sure it won't be the last. Spaces also cause various usability issues, including:
So I think we should consider naming directories with the spaceless app name, rather than the formal name as we do now. Of course, we'd still need to recognize the formal name in existing projects. |
Ugh. /me waves fist at clouds. FWIW, my test app for flatpak has been "Hello World" on an Ubuntu 22.04 box with flatpak-builder 1.2.2 and flatpak 1.12.7, and the space isn't a problem. However, I just tested on an Ubuntu 18.04 box with with flatpak-builder 1.0.14 and flatpak 1.12.7, and while the build completes, the run doesn't. Regardless, I think you're probably right - there's enough headaches in dealing with spaces that it's worth moving to using the app name as the bundle path. The annoying thing is that the formal name needs to be fixed in both briefcase and the template, which means the path to making this change is going to be complex. The (small) silver lining is that we've got a general policy that the contents of the build products are transient, and shouldn't be relied upon as permanent artefacts (i.e., they shouldn't be committed to version control); so we don't need to worry about migrating projects - we just need to work out how we're going to support "version of briefcase that is expecting to find code in A related thought: in order to address #424, I've been contemplating whether we should move to a directory structure more consistent with Python's packaging folders (i.e., a |
As another datapoint, the Flatpak build fails on Ubuntu 20.04.
|
@rmartin16 This is an issue with the version of flatpack-builder that ships with Ubuntu 20.04. We discovered this when we set up the verification builds in CI; until recently, the CI config had a comment. that specifically referenced this problem (at least partially because ubuntu-latest on Actions wasn't 22.04 until late last year). |
OS packages:
Briefcase commit 0d7c359
Running
briefcase run linux flatpak
on the default Hello World app, I get this output:briefcase.2022_07_28-20_53_54.run.log
The build and install appears to have succeeded, but the app isn't listed by
flatpak list
:Running the flatpak-builder command manually also appears to succeed, but the app still isn't listed.
This appears to be related to flatpak/flatpak#4378, except that instead of giving an error, the install just failed silently. If I rename the directory to remove the space, and rerun, then it works:
The text was updated successfully, but these errors were encountered: