feat: add experimental tls_native_roots feature #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoverbear
reviewed
Jul 5, 2024
cargo-dist/src/net.rs
Outdated
| // .tls_built_in_native_certs(*prefer_native_tls); | ||
| let client = builder | ||
| .build() | ||
| .expect("failed to intitalize http client"); |
There was a problem hiding this comment.
Suggested change
| .expect("failed to intitalize http client"); | |
| .expect("failed to initialize http client"); |
The main goal of this is actually updating axoasset to 1.0.0 and enabling the rusttls_native_tls feature as appropriate. This speculatively also adds a ClientSettings type which isn't really important but ensures all the places where we make clients are flagged for future updates.
Gankra
changed the title
mistydemeo
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this is actually updating axoasset to 1.0.0 and
enabling the tls_native_roots feature as appropriate.
This speculatively also adds a ClientSettings type which isn't really
important but ensures all the places where we make clients are flagged
for future updates.