feat: shared workspaces #1145
Merged
feat: shared workspaces #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This builds and passes tests locally, but there are several outstanding TODOs, and this isn't really tested until we change the gallery. |
mistydemeo
force-pushed
the
unity
branch
2 times, most recently
from
69393d9
to
c6aee9f
Compare
Gankra
force-pushed
the
unity
branch
2 times, most recently
from
97eceef
to
cb829e6
Compare
mistydemeo
reviewed
Jun 27, 2024
| #[derive(Debug, Error, Diagnostic)] | ||
| pub enum ProjectError { | ||
| /// No workspace found from axoproject | ||
| #[error("No workspace found; either your project doesn't have a Cargo.toml/dist.toml, or we couldn't read it")] |
There was a problem hiding this comment.
Do we also want to mention dist-workspace.toml?
Gankra
force-pushed
the
unity
branch
8 times, most recently
from
75aad7b
to
7a1964b
Compare
mistydemeo
approved these changes
Jul 11, 2024
| /// The unoverrideable name of the package within its own package management system. | ||
| /// | ||
| /// This may be needed when e.g. talking to cargo about the package. | ||
| pub true_name: String, |
This introduces a new axoproject WorkspaceGraph abstraction that exists to replace the old Workspaces approach. The purpose of this new abstraction is that it supports nested workspaces, while still allowing you to work with all the packages uniformly. Most code largely remains the same, as it looks up properties of packages by id, or queries a property of all workspaces/packages, where essentially nothing is changed. Also all logic to inherit config from workspaces to packages is just changed to inherit from the *root* package, as we don't want to support multiple `[workspace.metadata.dist]` entries. compute_build functions have been changed to take a workspace, so that we try to compute N cargo builds for N cargo workspaces (discarding them if unecessary). The URL code has once again been refactored to be more of a chain instead of redoing the same work over and over. The `package_info` subfield of a workspace has been deprecated in favour of Asking the WorkspaceGraph, as there are different tiers of childhood now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new axoproject WorkspaceGraph abstraction that exists to replace the old Workspaces approach. The purpose of this new abstraction is that it supports nested workspaces, while still allowing you to work with all the packages uniformly.
Most code largely remains the same, as it looks up properties of packages by id, or queries a property of all workspaces/packages, where essentially nothing is changed.
Also all logic to inherit config from workspaces to packages is just changed to inherit from the root package, as we don't want to support multiple
[workspace.metadata.dist]entries.compute_build functions have been changed to take a workspace, so that we try to compute N cargo builds for N cargo workspaces (discarding them if unecessary).
The URL code has once again been refactored to be more of a chain instead of redoing the same work over and over.
The
package_infosubfield of a workspace has been deprecated in favour of Asking the WorkspaceGraph, as there are different tiers of childhood now.