From 75c47c47fac61312d3ffdabb3d9914f5a35da1f5 Mon Sep 17 00:00:00 2001 From: Xinding Wei Date: Tue, 12 Sep 2023 15:16:31 -0400 Subject: [PATCH] [fix] max_rows in BaseCircuitBuilder in Keccak Leaf Circuit (#152) Fix max_rows in BaseCircuitBuilder inside Keccak Vanilla --- hashes/zkevm/src/keccak/coprocessor/circuit/leaf.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hashes/zkevm/src/keccak/coprocessor/circuit/leaf.rs b/hashes/zkevm/src/keccak/coprocessor/circuit/leaf.rs index 2fcd68ef..ddea15fb 100644 --- a/hashes/zkevm/src/keccak/coprocessor/circuit/leaf.rs +++ b/hashes/zkevm/src/keccak/coprocessor/circuit/leaf.rs @@ -136,10 +136,12 @@ impl Circuit for KeccakCoprocessorLeafCircuit { /// Configures a new circuit using [`BaseConfigParams`] fn configure_with_params(meta: &mut ConstraintSystem, params: Self::Params) -> Self::Config { + let keccak_circuit_config = KeccakCircuitConfig::new(meta, params.keccak_circuit_params); let base_circuit_params = params.base_circuit_params; + // BaseCircuitBuilder::configure_with_params must be called in the end in order to get the correct + // unusable_rows. let base_circuit_config = BaseCircuitBuilder::configure_with_params(meta, base_circuit_params.clone()); - let keccak_circuit_config = KeccakCircuitConfig::new(meta, params.keccak_circuit_params); Self::Config { base_circuit_config, keccak_circuit_config } }