Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considering a fork of this repo to get it usable again #354

Open
MrPowers opened this issue Mar 24, 2021 · 10 comments
Open

Considering a fork of this repo to get it usable again #354

MrPowers opened this issue Mar 24, 2021 · 10 comments

Comments

@MrPowers
Copy link
Contributor

Thanks again for making this project.

I did some searching / emailing to see if anyone is still maintaining this project and wasn't able to find anyone.

I'm considering making a fork of this repo, at least to publish Spark 3 JAR files that work (current Spark 3 JAR files are malformed).

Open to comments / suggestions and will let this sit for a bit before making the fork. No judgement BTW, companies / people can abandon open source whenever they want.

@aviatesk
Copy link
Contributor

aviatesk commented Mar 25, 2021

Hi, I already forked deequ and keep bugfixing and adding features here: https://github.com/aviatesk/deequ
You can find changes from the original deequ repository in CHANGELOG.
We're building the forked deequ ourselves and thus haven't released jars, but I'm welcome to do that if there is a demand for that.

I'm also planning to announce it as "being maintained deequ" somewhere (maybe as an issue of this repository).


Do we want to join the forces there ? Welcome to any suggestions or ideas.

@MrPowers
Copy link
Contributor Author

@aviatesk - glad to see you've already made great progress.

It'd be great it you could shift your fork to SBT & publish it to Maven. I can help if you're not familiar with the process.

We recently worked to publish itachi to Maven and the README of this project has good instructions.

Getting a properly built Spark 3 JAR file would be great for the community. Thank you for your efforts & keep me posted on progress ;)

@sscdotopen
Copy link
Contributor

I think this is a great idea. I lost my push access to this repository since I left Amazon, and I don't have time in my new job to work on Deequ anymore. I'd be happy to see it continued by a community!

@ets
Copy link

ets commented Mar 26, 2021

I've been maintaining my own fork after merging #299 for my own use - and would enthusiastically contribute to a new community.

@twollnik
Copy link
Contributor

Hi all. I'm really sorry, we haven't had much availability for deequ over the last months. Thank you all for contributing to the project! We are committed to fixing the jars by mid-April. We will also review our open-source commitments internally some time soon and might have more availability for deequ in the future. Thanks again!

@twollnik
Copy link
Contributor

Hi all. Thanks so much for your patience! We just had a team internal discussion about our future commitments for deequ. The main take away is that this project is important to us and we want to keep maintaining it. The last months have been very busy for us and we are sorry to have been so inactive on the deequ front. We don’t yet have a decision on how much time exactly we can allocate for deequ and as of now we can’t promise to implement new features. We will keep you updated in this issue when we have a more precise idea regarding our future availability. Please let us know in this issue if you have any questions or comments. Thanks again for all your contributions!

@konradwudkowski
Copy link

konradwudkowski commented Apr 28, 2021

hi @twollnik thanks a lot for your reply. It's great that you plan to maintain this project in the future. I understand the timeline for new features is not guaranteed, how about just getting it work on Spark 3? Is this something that may happen relatively soon?

@twollnik
Copy link
Contributor

Hi @konradwudkowski, you can already use deequ with spark 3 if your workflow includes attaching jars directly to clusters (use the jar here: https://mvnrepository.com/artifact/com.amazon.deequ/deequ/1.1.0_spark-3.0-scala-2.12). ETA for a spark 3 release that can be imported with sbt or maven is next week.

@MrPowers
Copy link
Contributor Author

@konradwudkowski - FYI, Deequ is working with Spark 3 now, see here: #353 (comment).

@joshivinay
Copy link

I have my own fork as well, which we use to extend functionality. A lot of the code is in private[deequ] scope which doesnt lend for extension very well unless we create the exact same package hierarchy within our code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants