Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix NodeJS Client is using undefined http agent issue #4453

Merged
merged 4 commits into from
Jul 7, 2023
Merged

fix NodeJS Client is using undefined http agent issue #4453

merged 4 commits into from
Jul 7, 2023

Conversation

pivstone
Copy link
Contributor

@pivstone pivstone commented Jun 21, 2023 •
edited
Loading

A suggestion fix for issue: #4452

Checklist
  • npm run test passes
  • .d.ts file is updated
  • changelog is added, npm run add-change
  • run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
  • run npm run integration if integration test is changed
  • non-code related change (markdown/git settings etc)

@pivstone pivstone mentioned this pull request Jun 21, 2023
Closed
@pivstone pivstone marked this pull request as ready for review June 21, 2023 16:03
@pivstone pivstone requested a review from a team as a code owner June 21, 2023 16:03
@pivstone @trivikr
Update .changes/next-release/bugfix-NodeJS-Client-80bdf3e3.json
f5c42a1 
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
@pivstone pivstone requested a review from trivikr June 26, 2023 11:46
@siddsriv siddsriv merged commit a4b2ea8 into aws:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhe kuhe kuhe approved these changes

@trivikr trivikr Awaiting requested review from trivikr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pivstone @kuhe @trivikr @siddsriv