fix NodeJS Client is using undefined http agent issue (#4453)

* test: add unit test to reproduce the issue * fix: change the update line order * chore: code lint fix * Update .changes/next-release/bugfix-NodeJS-Client-80bdf3e3.json Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> --------- Co-authored-by: Ray Wang <> Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
aws · Jul 7, 2023 · a4b2ea8 · a4b2ea8
1 parent 7e35f37
commit a4b2ea8
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/.changes/next-release/bugfix-NodeJS-Client-80bdf3e3.json b/.changes/next-release/bugfix-NodeJS-Client-80bdf3e3.json
@@ -0,0 +1,5 @@
+{
+  "type": "bugfix",
+  "category": "node",
+  "description": "use undefined node http agent if explicitly passed by user"
+}
diff --git a/lib/http/node.js b/lib/http/node.js
@@ -32,13 +32,14 @@ AWS.NodeHttpClient = AWS.util.inherit({
       path: pathPrefix + httpRequest.path
     };
 
+    AWS.util.update(options, httpOptions);
+
     if (!httpOptions.agent) {
       options.agent = this.getAgent(useSSL, {
         keepAlive: process.env[CONNECTION_REUSE_ENV_NAME] === '1' ? true : false
       });
     }
 
-    AWS.util.update(options, httpOptions);
     delete options.proxy; // proxy isn't an HTTP option
     delete options.timeout; // timeout isn't an HTTP option
 

diff --git a/test/node_http_client.spec.js b/test/node_http_client.spec.js