Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] example code is invalid (pricing.NewGetAttributeValuesPaginator) #839

Closed
skyzyx opened this issue Oct 20, 2020 · 1 comment
Labels
closed-for-staleness documentation This is a problem with documentation. duplicate This issue is a duplicate.

Comments

@skyzyx
Copy link

skyzyx commented Oct 20, 2020

Describe the issue with documentation

The example code is invalid in https://pkg.go.dev/github.com/aws/aws-sdk-go-v2@v0.24.0/service/pricing#NewGetAttributeValuesPaginator

// Example iterating over pages.
req := client.GetAttributeValuesRequest(input)
p := pricing.NewGetAttributeValuesRequestPaginator(req)

for p.Next(context.TODO()) {
    page := p.CurrentPage()
}

if err := p.Err(); err != nil {
    return err
}

pricing.NewGetAttributeValuesRequestPaginator should be pricing.NewGetAttributeValuesPaginator.

@skyzyx skyzyx added the documentation This is a problem with documentation. label Oct 20, 2020
@jasdel jasdel added duplicate This issue is a duplicate. closing-soon This issue will automatically close in 4 days unless further comments are made. labels Oct 21, 2020
@jasdel
Copy link
Contributor

jasdel commented Oct 21, 2020

Thanks for reaching out @skyzyx with this. I think we can mark this as a duplicate of #439 since paginators are not available in the v2 preview SDK, after the v0.25.0 update.

This documentation is for v0.24.0 of the SDK, before the refactor, and once we release paginator's feature they will be contain the correct documentation.

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Oct 22, 2020
@jasdel jasdel added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Oct 23, 2020
@github-actions github-actions bot added closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness documentation This is a problem with documentation. duplicate This issue is a duplicate.
Projects
None yet
Development

No branches or pull requests

2 participants