Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use assert.PanicsWithValue #541

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

wafuwafu13
Copy link
Contributor

Issue #, if available:

Description of changes:

Change to use assert.PanicsWithValue
https://pkg.go.dev/github.com/stretchr/testify/assert#PanicsWithValue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c42f056) 72.93% compared to head (76b607c) 72.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #541   +/-   ##
=======================================
  Coverage   72.93%   72.93%           
=======================================
  Files          26       26           
  Lines        1456     1456           
=======================================
  Hits         1062     1062           
  Misses        322      322           
  Partials       72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bmoffatt bmoffatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thanks!

@bmoffatt bmoffatt merged commit f079271 into aws:main Dec 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants