From f0792716d3cb62d45772c5523d7abcd2117ce8aa Mon Sep 17 00:00:00 2001 From: Hirotaka Tagawa / wafuwafu13 Date: Fri, 22 Dec 2023 00:07:33 +0000 Subject: [PATCH] refactor: use assert.PanicsWithValue (#541) --- events/attributevalue_test.go | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/events/attributevalue_test.go b/events/attributevalue_test.go index 551c9d1c..b1b68233 100644 --- a/events/attributevalue_test.go +++ b/events/attributevalue_test.go @@ -215,25 +215,10 @@ func TestAccessWithWrongTypePanics(t *testing.T) { var av DynamoDBAttributeValue err := json.Unmarshal([]byte(testCase.input), &av) assert.Nil(t, err) - // may use PanicsWithValue(expectedError) when it is available - assertPanicsWithValue(t, testCase.expectedError, func() { testCase.accessor(av) }) + assert.PanicsWithValue(t, testCase.expectedError, func() { testCase.accessor(av) }) } } -func assertPanicsWithValue(t *testing.T, expected error, action func()) { - defer func() { - r := recover() - if r == nil { - t.Errorf("Should have panicked") - } - if r != expected { - t.Errorf("should have panicked with value %v but panicked with value %v", expected, r) - } - }() - - action() -} - func TestMarshalAndUnmarshalString(t *testing.T) { const inputString = "INPUT STRING" inputValue := NewStringAttribute(inputString)