Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yarn dependency from example-contracts AND CI #660

Closed
richardpringle opened this issue May 29, 2023 · 3 comments · Fixed by #672
Closed

Remove yarn dependency from example-contracts AND CI #660

richardpringle opened this issue May 29, 2023 · 3 comments · Fixed by #672
Assignees
Labels
enhancement New feature or request

Comments

@richardpringle
Copy link
Contributor

Context and scope
While yarn might be better than NPM, I really don't think it makes sense to have an extra dependency. Those who prefer yarn will know how to do yarn equivalents when it comes to documentation.

for CI, we should use the command npm ci which will grab all the exact dependencies that are in the package-lock.json.

Discussion and alternatives
Open to alternatives, but the fewer external dependencies, the better IMO.

Open questions
N/A

@richardpringle richardpringle added the enhancement New feature or request label May 29, 2023
@richardpringle
Copy link
Contributor Author

@ceyonur, I assigned this to you... but that doesn't mean you need to do it haha. If you don't have time or whatever, feel free to assign it back to me and I'll get to it at some point in the future.

@ceyonur ceyonur linked a pull request Jun 16, 2023 that will close this issue
@ceyonur
Copy link
Collaborator

ceyonur commented Jun 16, 2023

will be closed by #672

@ceyonur ceyonur mentioned this issue Jun 16, 2023
6 tasks
@richardpringle
Copy link
Contributor Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants