Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Takes couple of seconds to redraw #11

Open
martinkrcho opened this issue Sep 15, 2015 · 2 comments
Open

Takes couple of seconds to redraw #11

martinkrcho opened this issue Sep 15, 2015 · 2 comments

Comments

@martinkrcho
Copy link

I really like the idea behind this project and I would like to use it on my websites, but I am struggling with one huge downside. The pagination takes couple of seconds to redraw when I change the size of its container (or browser). As you can imagine, no one should have something that slow on their website. Have anyone noticed this issue? Is there a way to speed it up?

@acoulton
Copy link
Contributor

We had the same issue - performance was basically unusable - and proposed a fix in #5. @auxiliary found some edge case issues which we've not had a chance to look at, our version is in production at https://www.edbookfest.co.uk/the-festival/events and we've not had problems reported. Ultimately I can cope with the occasional rendering bug vs the very heavy impact on page response time that we were seeing. We'll be keeping the https://github.com/craig410/rpage fork up for the foreseeable future if you want to use it.

@auxiliary
Copy link
Owner

@acoulton The problem mentioned in #5 only occurs on a resize and not on a load, and apparently only when you're on a page that needs hiding from both ends. You can reproduce the bug by loading a page like this one with a smaller browser size and then increasing the width of the browser (Chrome 44 in my case). This would be the results:

screenshot from 2015-09-15 09 35 31

Other than that the solution in #5 is pretty effective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants