Skip to content
This repository has been archived by the owner on May 17, 2023. It is now read-only.

Allow to have nothing selected on Select #934

Merged
merged 5 commits into from
Sep 28, 2018
Merged

Allow to have nothing selected on Select #934

merged 5 commits into from
Sep 28, 2018

Conversation

francocorreasosa
Copy link
Contributor

@francocorreasosa francocorreasosa commented Sep 24, 2018 •
edited
Loading

Default

image

With custom empty option text

image

Fixes #925

landitus
landitus approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@landitus landitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddharthkp
Copy link
Contributor

Sorry, tiny change: Let's rename emptyTag to placeholder to match it's input siblings

@siddharthkp siddharthkp added the 🚀 release: minor new features and non-breaking changes label Sep 28, 2018
@siddharthkp siddharthkp merged commit 45c235b into master Sep 28, 2018
@siddharthkp siddharthkp deleted the fix-select-nothing-selected branch September 28, 2018 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@siddharthkp siddharthkp siddharthkp left review comments

@landitus landitus landitus approved these changes

Assignees
No one assigned
Labels
🖼️design / ux Design enhancements ✨enhancement ...improvements 🚀 release: minor new features and non-breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francocorreasosa @siddharthkp @landitus