-
Notifications
You must be signed in to change notification settings - Fork 114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francocorreasosa I build it and it moves :) As far as the code goes I can't really review it, I'd just make sure that actions and links work when they are clicked.
@landitus I think there is a need for some kind of indication that the list is sortable. If we can't add new elements because we need to match the style guide, I suggest we at least change the cursor to cursor: move
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francocorreasosa Let me mockup the design with the necessary handles that will indicate this List can be re-ordered via drag and drop. I will place it here so you can continue.
Sounds good @landitus, thank you |
@francocorreasosa When @landitus is done with the design please let me know, positioning them can be a challenge and we might do a larger refactor on the resource list to make it accessible, improve the HTML and the CSS while we are it. It might take a little bit more time, but its nothing we can't solve together in a day or 2. What do you think? |
Sounds like a good idea @andresgalante, let's start planning that as soon as we merge this |
@francocorreasosa Here's a design mockup for the Re-order feature. Let me know if there is something missing. I can walk you through it, as well. |
… sortable-resource-list
@landitus I've added the |
@landitus using this outline design in the meantime to differentiate the selected and non-selected row items: |
Thanks @francocorreasosa ! Just did a small adjustment to the focus state. You can check the updated invision prototype too. |
@landitus It should be fixed by now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Now, the `sortable` prop can be used to make the list sortable by dragging and dropping items. You will need to implement the `onSortEnd` method in order to reorder the items using the provided `arrayMove` ![kapture 2018-12-04 at 18 22 31](https://user-images.githubusercontent.com/4152942/49473729-9bed4f80-f7f1-11e8-87c3-5638d8d95bac.gif)
Now, the
sortable
prop can be used to make the list sortable by dragging and dropping items. You will need to implement theonSortEnd
method in order to reorder the items using the providedarrayMove