From 2f2a07b2d14b5826c7ec4b2dea721e1747b2d287 Mon Sep 17 00:00:00 2001
From: Jeff Ortel <jortel@redhat.com>
Date: Mon, 16 Oct 2023 16:50:12 -0500
Subject: [PATCH] :sparkles: Better pod OOM reporting. (#521)

Using the container status `Reason` for more accurate reporting.
```
state: Failed
image: quay.io/jortel/tackle2-addon-analyzer:debug
pod: konveyor-tackle/task-13-gcmjs
retries: 1
started: 2023-10-16T10:36:30.221282042-07:00
terminated: 2023-10-16T10:36:40.301254088-07:00
bucket:
    id: 17
    name: ""
errors:
    - severity: Error
      description: 'Pod failed: OOMKilled'
```

Also, the RWX should be disabled by default.

---------

Signed-off-by: Jeff Ortel <jortel@redhat.com>
---
 settings/hub.go | 2 --
 task/manager.go | 5 ++++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/settings/hub.go b/settings/hub.go
index d7d984e8..deaf0c00 100644
--- a/settings/hub.go
+++ b/settings/hub.go
@@ -106,8 +106,6 @@ func (r *Hub) Load() (err error) {
 	if found {
 		b, _ := strconv.ParseBool(s)
 		r.Cache.RWX = b
-	} else {
-		r.Cache.RWX = true
 	}
 	r.Cache.PVC, found = os.LookupEnv(EnvCachePvc)
 	if !found {
diff --git a/task/manager.go b/task/manager.go
index 524923d2..172fc0f8 100644
--- a/task/manager.go
+++ b/task/manager.go
@@ -356,7 +356,10 @@ func (r *Task) Reflect(client k8s.Client) (err error) {
 		r.State = Succeeded
 		r.Terminated = &mark
 	case core.PodFailed:
-		r.Error("Error", "Pod failed: %s", pod.Status.Message)
+		r.Error(
+			"Error",
+			"Pod failed: %s",
+			pod.Status.ContainerStatuses[0].State.Terminated.Reason)
 		switch pod.Status.ContainerStatuses[0].State.Terminated.ExitCode {
 		case 137: // Killed.
 			if r.Retries < Settings.Hub.Task.Retries {