From 333f3e396822bd0c6260f3f408f9b6569409ba0d Mon Sep 17 00:00:00 2001 From: Nick Campbell Date: Tue, 28 May 2024 08:51:08 +0100 Subject: [PATCH] Make "enable_batching" parameter viewable, optional, default false There are tradeoffs associated with Segment event batching - there is no realtime feedback if the request was invalid, for example - so we should make it opt-in and controllable by the user. --- .../src/destinations/attio/common-fields.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/destination-actions/src/destinations/attio/common-fields.ts b/packages/destination-actions/src/destinations/attio/common-fields.ts index 73674cb64f..0911471da9 100644 --- a/packages/destination-actions/src/destinations/attio/common-fields.ts +++ b/packages/destination-actions/src/destinations/attio/common-fields.ts @@ -4,11 +4,11 @@ import { Settings } from './generated-types' export const commonFields: ActionDefinition['fields'] = { enable_batching: { label: 'Send data to Attio in batches', - description: 'Send data to Attio in batches for much better performance.', + description: + 'Send batches of events to Attio, for improved performance, however invalid events are silently dropped.', type: 'boolean', required: false, - unsafe_hidden: true, - default: true + default: false }, batch_size: {