Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

RFE: remove pusher.com dependency #393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nonameentername
Copy link

Please be sure to read the contributor's guide before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

Updated teletype-server to use different external dependencies. Replaced Twilio with Coturn and Pusher with SocketCluster.

Alternate Designs

SocketCluster could be replaced with a separate library that handles pubSub.

Benefits

It is possible to run teletype-server without having to use external dependencies.

Possible Drawbacks

Verification Process

Ran teletype-server with coturn and socketcluster and verified that atom could establish a shared session.

Applicable Issues

atom/teletype-server#35

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant