-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically change the reference point when dragging #517
Comments
We have put a lot of time into creating an experience that works well regardless of item size as well as the sizes of the other items in the list: https://github.com/atlassian/react-beautiful-dnd#application-2-knowing-when-to-move
This is enforced provide a consistant and natural experience. Are you proposing an enhancement to this? |
This looks like a really interesting enhancement |
In addition, if start dragging between different widths of the droppable containers. When dragging from a wider to a narrower droppable, the center of the dragged element is expected. It not look obvious. Does there is possibility for dropping element, if dragging cursor was over dropping container? |
We do not use the selection position because:
I am keen not to get distracted from your original suggestion in this issue. Please create other issues if you think there are other parts of the library that are worth discussing. Cheers |
I have not forgotten about this one! The logic for this would need to be direction aware. It looks like we are adding some internal logic that could make this change possible |
It turns out we need to get this right in order for #511 to work correctly. I currently have this working in home lists, I am now looking into foreign lists |
Any news on that topic? |
This will be shipping in #719. I'll keep this open until that ships |
Going out in #838 |
Closed by #838. See version 10 release notes |
ignoreContainerClipping={true} |
Bug or feature request?
Feature request
I saw that in the examples the draggables has much the same widths/heights. I'm trying to use the API in a vertical list, but with longer and shorter elements too. I realized that if an element is dragging, the order gets changing if the actual draggable's center reaches the draggable's border next to it. It looks a bit disappointing if the draggable which is dragging a much longer element than it's "siblings". My idea is that if the dragging was started, check the draggable's width, and check the elements width which are next to it. If the actual element's width is shorter than the element which is next to them, the reference point is the actual element's center. If the actual element's width is longer than the next element, set the reference point to the element's center which is next to the actual element.
Expected behavior
Actual behavior
Steps to reproduce
Browser version
Demo
The text was updated successfully, but these errors were encountered: