Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded app icon #3

Open
HEXcube opened this issue Apr 23, 2016 · 0 comments
Open

Fix hardcoded app icon #3

HEXcube opened this issue Apr 23, 2016 · 0 comments

Comments

@HEXcube
Copy link

HEXcube commented Apr 23, 2016

As u can see from pomodoro-indicator's desktop file, app icon is wrongly placed in /opt/extras.ubuntu.com/pomodoro-indicator/bin/pomodoro-indicator and Icon= field set to a hardcoded path. 😟

According to freedesktop icon naming specification (the standard for Linux desktop), the correct way to declare icon in desktop file is:

Icon=pomodoro-indicator

For this change to work, pomodoro-indicator.svg icon has to be installed in the standard icon location:

/usr/share/icons/hicolor/scalable/apps/pomodoro-indicator.svg

Fixing this has the additional benefit of adding icon theme compatibility to Pomodoro Indicator's desktop entry. ☺️ See: What are hardcoded icons? and Foggalong/hardcode-fixer#221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant