Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror script runs for yanked releases #10

Open
zanieb opened this issue Jun 21, 2024 · 1 comment · May be fixed by #11
Open

Mirror script runs for yanked releases #10

zanieb opened this issue Jun 21, 2024 · 1 comment · May be fixed by #11

Comments

@zanieb
Copy link
Member

zanieb commented Jun 21, 2024

See #9

Tracking this as something we should fix eventually.
@CoderJoshDK
Copy link
Contributor

I looked into this a little. And I think I have a "solution". Basically just change:

uv-pre-commit/mirror.py

Line 35 in 9d6994f

versions = [Version(release) for release in response.json()["releases"]]

Instead, you (I can do it) would check the json object's list of releases and look for any parts that were yanked. If so, don't add it to the list. The two biggest issues with this, is that there is no way to auto undo a commit (not with this structure at least). And if that is a desired behavior, it would require more reworking (but it is possible). The other "issue" is that this check would become much slower. A non issue, though, really.

So I guess the standing question, is if you need the system to auto undo a yanked release?

Release version object 

 "0.1.0": [
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "0ce3415f40a86918316951b69b42661731bf6c5e5007f4063bc564773aec4815",
          "md5": "1b2bdf4f82219f3131e4833ccba91c96",
          "sha256": "71291b3b3222da25a6af5ab9dfaec3bdd97fd4f0d21cf38a04cbd63000fa9da5"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-macosx_10_12_x86_64.macosx_11_0_arm64.macosx_10_12_universal2.whl",
        "has_sig": false,
        "md5_digest": "1b2bdf4f82219f3131e4833ccba91c96",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 18578356,
        "upload_time": "2024-02-15T19:44:47",
        "upload_time_iso_8601": "2024-02-15T19:44:47.783250Z",
        "url": "https://files.pythonhosted.org/packages/0c/e3/415f40a86918316951b69b42661731bf6c5e5007f4063bc564773aec4815/uv-0.1.0-py3-none-macosx_10_12_x86_64.macosx_11_0_arm64.macosx_10_12_universal2.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "a5b6a84735682ce516f1c8890eaff243f9ad825081a484f7bde943625c797877",
          "md5": "03332880fd4568e5627aad168374eb66",
          "sha256": "093049b60277afbc2bfcc1905cd6848b3677e9f0f1c96971ff69c7451acb4c3c"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-macosx_10_12_x86_64.whl",
        "has_sig": false,
        "md5_digest": "03332880fd4568e5627aad168374eb66",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 9275976,
        "upload_time": "2024-02-15T19:44:52",
        "upload_time_iso_8601": "2024-02-15T19:44:52.996180Z",
        "url": "https://files.pythonhosted.org/packages/a5/b6/a84735682ce516f1c8890eaff243f9ad825081a484f7bde943625c797877/uv-0.1.0-py3-none-macosx_10_12_x86_64.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "796ab14e0e7e9fcff64a42f5e7fb1b63ad44ba2a35db22f74f170b9c5f57c5e6",
          "md5": "76791c8216f8e735cdb86c4bef0e13ef",
          "sha256": "acaeeeda2622ca6c3eb9071fefd2820b498aef14ce82814b680ced6dee718760"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-manylinux_2_17_i686.manylinux2014_i686.whl",
        "has_sig": false,
        "md5_digest": "76791c8216f8e735cdb86c4bef0e13ef",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 10187899,
        "upload_time": "2024-02-15T19:44:56",
        "upload_time_iso_8601": "2024-02-15T19:44:56.173678Z",
        "url": "https://files.pythonhosted.org/packages/79/6a/b14e0e7e9fcff64a42f5e7fb1b63ad44ba2a35db22f74f170b9c5f57c5e6/uv-0.1.0-py3-none-manylinux_2_17_i686.manylinux2014_i686.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "8075f778c04dc2c9dd53cda6c264eef72d3c4971b8397aecb71b2a2713f285c6",
          "md5": "32346f7c9f28914da2c240050f54a768",
          "sha256": "44ff0a511c97633ce2d999f25816cccb1f89e95c911fe319136ea9e9582db6dc"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-manylinux_2_17_ppc64le.manylinux2014_ppc64le.whl",
        "has_sig": false,
        "md5_digest": "32346f7c9f28914da2c240050f54a768",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 10640687,
        "upload_time": "2024-02-15T19:45:04",
        "upload_time_iso_8601": "2024-02-15T19:45:04.093178Z",
        "url": "https://files.pythonhosted.org/packages/80/75/f778c04dc2c9dd53cda6c264eef72d3c4971b8397aecb71b2a2713f285c6/uv-0.1.0-py3-none-manylinux_2_17_ppc64le.manylinux2014_ppc64le.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "697dac10635eda340fd3c74bdda2e903bb1f31a02c08d8c9c96c168a6b072cd1",
          "md5": "dd65caac219faccfd10dfc19763d444f",
          "sha256": "a58bccee207dfa24f8c9cae3ad5bed08e85ef3e643fc8a5fde1a26e00671ec76"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-manylinux_2_17_ppc64.manylinux2014_ppc64.whl",
        "has_sig": false,
        "md5_digest": "dd65caac219faccfd10dfc19763d444f",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 11066323,
        "upload_time": "2024-02-15T19:44:59",
        "upload_time_iso_8601": "2024-02-15T19:44:59.738504Z",
        "url": "https://files.pythonhosted.org/packages/69/7d/ac10635eda340fd3c74bdda2e903bb1f31a02c08d8c9c96c168a6b072cd1/uv-0.1.0-py3-none-manylinux_2_17_ppc64.manylinux2014_ppc64.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "2fd32b1b3aeb8e9268e677e7eb174ccbf3c4eb85bccad57eececdf10f7b18407",
          "md5": "040f6c181b01974fb1738e312fcb1535",
          "sha256": "3130fcc09c93e6f6b96e74f307b4010cf6d3a3db44b66b8f81ba7ed95d45c839"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-manylinux_2_17_s390x.manylinux2014_s390x.whl",
        "has_sig": false,
        "md5_digest": "040f6c181b01974fb1738e312fcb1535",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 10493717,
        "upload_time": "2024-02-15T19:45:07",
        "upload_time_iso_8601": "2024-02-15T19:45:07.252427Z",
        "url": "https://files.pythonhosted.org/packages/2f/d3/2b1b3aeb8e9268e677e7eb174ccbf3c4eb85bccad57eececdf10f7b18407/uv-0.1.0-py3-none-manylinux_2_17_s390x.manylinux2014_s390x.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "bc1ac974db539c542ef25af8d072497bae9a685edda91399391f0ba14dcd3177",
          "md5": "a860eb7ff0da68fb5e380bf43d425d76",
          "sha256": "aa5b37239c1011450b4b21e5e2cff727e8fb13d25ca4cd818137b0291e14fb6f"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl",
        "has_sig": false,
        "md5_digest": "a860eb7ff0da68fb5e380bf43d425d76",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 10135915,
        "upload_time": "2024-02-15T19:45:10",
        "upload_time_iso_8601": "2024-02-15T19:45:10.513183Z",
        "url": "https://files.pythonhosted.org/packages/bc/1a/c974db539c542ef25af8d072497bae9a685edda91399391f0ba14dcd3177/uv-0.1.0-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "50690cef44dc60a7bd034a75eaa395f182fb4191d791b781665b94cbbd045979",
          "md5": "fce8026f985c1bd7bad8ad2832161ed3",
          "sha256": "7b8289914256e7926ba1e89a99c7ef40c7d73f67e7ba7f08ff9efb7dd60189c5"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-manylinux_2_28_aarch64.whl",
        "has_sig": false,
        "md5_digest": "fce8026f985c1bd7bad8ad2832161ed3",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 9934270,
        "upload_time": "2024-02-15T19:45:13",
        "upload_time_iso_8601": "2024-02-15T19:45:13.475849Z",
        "url": "https://files.pythonhosted.org/packages/50/69/0cef44dc60a7bd034a75eaa395f182fb4191d791b781665b94cbbd045979/uv-0.1.0-py3-none-manylinux_2_28_aarch64.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "3c1e3d3e580b3445d80c2840f69123fd9c4158ba9f4842d8fb157b2c94bc019e",
          "md5": "dee6f2a55e29052d176d8b516fe529f5",
          "sha256": "999621267d01b25f249435e32bd75efcf89c5e59ffc035b1c28accc99824c02c"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-manylinux_2_28_armv7l.whl",
        "has_sig": false,
        "md5_digest": "dee6f2a55e29052d176d8b516fe529f5",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 8595973,
        "upload_time": "2024-02-15T19:45:16",
        "upload_time_iso_8601": "2024-02-15T19:45:16.318553Z",
        "url": "https://files.pythonhosted.org/packages/3c/1e/3d3e580b3445d80c2840f69123fd9c4158ba9f4842d8fb157b2c94bc019e/uv-0.1.0-py3-none-manylinux_2_28_armv7l.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "e7735367cc3b560d0f2f7348c6ad4fe917accf9f589bb800c928fb98139561f7",
          "md5": "7791b35d8bdccfea69338c63f5501885",
          "sha256": "1a9441d235c6f3bb47ef0247da25640ec956493aeeb2b2a104843aab30c81725"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-musllinux_1_2_aarch64.whl",
        "has_sig": false,
        "md5_digest": "7791b35d8bdccfea69338c63f5501885",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 9812109,
        "upload_time": "2024-02-15T19:45:19",
        "upload_time_iso_8601": "2024-02-15T19:45:19.811604Z",
        "url": "https://files.pythonhosted.org/packages/e7/73/5367cc3b560d0f2f7348c6ad4fe917accf9f589bb800c928fb98139561f7/uv-0.1.0-py3-none-musllinux_1_2_aarch64.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "76dfeb5de3d90f0f03bc869d9b12456b7cfa0483940e158c0bd56a6e1188f304",
          "md5": "8e60828064f7e325a4346b34334c042f",
          "sha256": "5a66c55a2ad4614f333ea250c9c07989be8ab8a829beb4190c295a00b821db9e"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-musllinux_1_2_armv7l.whl",
        "has_sig": false,
        "md5_digest": "8e60828064f7e325a4346b34334c042f",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 8570944,
        "upload_time": "2024-02-15T19:45:22",
        "upload_time_iso_8601": "2024-02-15T19:45:22.435844Z",
        "url": "https://files.pythonhosted.org/packages/76/df/eb5de3d90f0f03bc869d9b12456b7cfa0483940e158c0bd56a6e1188f304/uv-0.1.0-py3-none-musllinux_1_2_armv7l.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "37bc38d69248a3cadc358548a462ccee71faaffc9fd30756fddbb59b5d2e7202",
          "md5": "b29b935e12c67eda9453247719575239",
          "sha256": "f81f63e82baccb528448c57faea9cc92d34e3550005375d5c801a1f273883fda"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-musllinux_1_2_i686.whl",
        "has_sig": false,
        "md5_digest": "b29b935e12c67eda9453247719575239",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 9661945,
        "upload_time": "2024-02-15T19:45:25",
        "upload_time_iso_8601": "2024-02-15T19:45:25.641882Z",
        "url": "https://files.pythonhosted.org/packages/37/bc/38d69248a3cadc358548a462ccee71faaffc9fd30756fddbb59b5d2e7202/uv-0.1.0-py3-none-musllinux_1_2_i686.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "809d43647d273f5e7544ca3ef7467db427c937d90e19b1e058990fef0502d070",
          "md5": "dc7d231da96e603aa9fc088cea9b7b28",
          "sha256": "bde6a79f37e29b7ab0d7b0535c47bb00d2b25605f695aa55e5e6e7396f908d33"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-musllinux_1_2_x86_64.whl",
        "has_sig": false,
        "md5_digest": "dc7d231da96e603aa9fc088cea9b7b28",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 10243008,
        "upload_time": "2024-02-15T19:45:28",
        "upload_time_iso_8601": "2024-02-15T19:45:28.246419Z",
        "url": "https://files.pythonhosted.org/packages/80/9d/43647d273f5e7544ca3ef7467db427c937d90e19b1e058990fef0502d070/uv-0.1.0-py3-none-musllinux_1_2_x86_64.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "0bc8bb23f5fab43e435a2a0d647ee8222c9b6b5165a161847bd655e8b63f53d6",
          "md5": "36c397967e77fd9f91a0e61207e4f686",
          "sha256": "9ec89bd44b3d305aa0de9ec6c219e4ab35d71febf4b473fa5d9ea516262ad77d"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-win32.whl",
        "has_sig": false,
        "md5_digest": "36c397967e77fd9f91a0e61207e4f686",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 7094875,
        "upload_time": "2024-02-15T19:45:31",
        "upload_time_iso_8601": "2024-02-15T19:45:31.901698Z",
        "url": "https://files.pythonhosted.org/packages/0b/c8/bb23f5fab43e435a2a0d647ee8222c9b6b5165a161847bd655e8b63f53d6/uv-0.1.0-py3-none-win32.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "8e81198492aa77532fba2c1fa8c3654e197e67e7dffcf1059b097bcb4b9df800",
          "md5": "0068c9360f767cc20aace1030d4ca1c0",
          "sha256": "2ddf5a4870c690bbd279dfc4472af6d780c3b2daf05d03097f54e4c9a827123a"
        },
        "downloads": -1,
        "filename": "uv-0.1.0-py3-none-win_amd64.whl",
        "has_sig": false,
        "md5_digest": "0068c9360f767cc20aace1030d4ca1c0",
        "packagetype": "bdist_wheel",
        "python_version": "py3",
        "requires_python": ">=3.8",
        "size": 8011536,
        "upload_time": "2024-02-15T19:45:34",
        "upload_time_iso_8601": "2024-02-15T19:45:34.397447Z",
        "url": "https://files.pythonhosted.org/packages/8e/81/198492aa77532fba2c1fa8c3654e197e67e7dffcf1059b097bcb4b9df800/uv-0.1.0-py3-none-win_amd64.whl",
        "yanked": false,
        "yanked_reason": null
      },
      {
        "comment_text": "",
        "digests": {
          "blake2b_256": "394314eac6b83b91f63045c3e3ea63a8ad2120149928e7ea266d0297664943cf",
          "md5": "64325146c389d2012556f9eb9323f6cc",
          "sha256": "93015f29d11855fa38b607703f244a0c5d59606d3401a6be63e1230c67292844"
        },
        "downloads": -1,
        "filename": "uv-0.1.0.tar.gz",
        "has_sig": false,
        "md5_digest": "64325146c389d2012556f9eb9323f6cc",
        "packagetype": "sdist",
        "python_version": "source",
        "requires_python": ">=3.8",
        "size": 1535213,
        "upload_time": "2024-02-15T19:45:36",
        "upload_time_iso_8601": "2024-02-15T19:45:36.163115Z",
        "url": "https://files.pythonhosted.org/packages/39/43/14eac6b83b91f63045c3e3ea63a8ad2120149928e7ea266d0297664943cf/uv-0.1.0.tar.gz",
        "yanked": false,
        "yanked_reason": null
      }
    ]

As you can see, each sub object has a "yanked": false,. Just check if any of them are set to "yanked": true,; if so, invalidate the version.

@CoderJoshDK CoderJoshDK linked a pull request Jun 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: gracefully handle yanked (head) releases CoderJoshDK/uv-pre-commit
2 participants
@zanieb @CoderJoshDK