From 4f678e2797cdd59734754732341ff6c73d62f3d1 Mon Sep 17 00:00:00 2001 From: Andrey Velichkevich Date: Tue, 28 May 2019 03:23:53 -0700 Subject: [PATCH] Check error in OpenSQLConnection (#588) * Check error in openSQLconn * Add logic in v1alpha1 * Change to Errorf --- pkg/db/v1alpha1/interface.go | 3 +++ pkg/db/v1alpha2/interface.go | 3 +++ 2 files changed, 6 insertions(+) diff --git a/pkg/db/v1alpha1/interface.go b/pkg/db/v1alpha1/interface.go index 5bc9c48f368..781a7d65e0e 100644 --- a/pkg/db/v1alpha1/interface.go +++ b/pkg/db/v1alpha1/interface.go @@ -111,6 +111,9 @@ func openSQLConn(driverName string, dataSourceName string, interval time.Duratio if err = db.Ping(); err == nil { return db, nil } + klog.Errorf("Ping to Katib db failed: %v", err) + } else { + klog.Errorf("Open sql connection failed: %v", err) } case <-timeoutC: return nil, fmt.Errorf("Timeout waiting for DB conn successfully opened.") diff --git a/pkg/db/v1alpha2/interface.go b/pkg/db/v1alpha2/interface.go index 5b8fc5bca4e..97317967b77 100644 --- a/pkg/db/v1alpha2/interface.go +++ b/pkg/db/v1alpha2/interface.go @@ -95,6 +95,9 @@ func openSQLConn(driverName string, dataSourceName string, interval time.Duratio if err = db.Ping(); err == nil { return db, nil } + klog.Errorf("Ping to Katib db failed: %v", err) + } else { + klog.Errorf("Open sql connection failed: %v", err) } case <-timeoutC: return nil, fmt.Errorf("Timeout waiting for DB conn successfully opened.")