Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jubako/arx): scaffold jubako/arx #24976

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

NikitaCOEUR
Copy link
Contributor

@NikitaCOEUR NikitaCOEUR commented Jul 16, 2024

jubako/arx: Store files and directory in an archive. Like tar, but faster and with direct random access

$ aqua g -i jubako/arx

Check List

System Prerequisites

I don't know if you want to distribute tools which have a system dependency.
This one have the lib "libfuse2" as dependencies as we can see when we launch it first time :

$ arx
arx: error while loading shared libraries: libfuse.so.2: cannot open shared object file: No such file or directory

This can be fixed with "libfuse2" installed :

$ sudo apt-get install -y libfuse2

How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.

Command and output

$ arx                     
A file archive based on Jubako container.

Usage: arx [OPTIONS] [COMMAND]

Commands:
  create   Create an archive
  list     List the content in an archive
  dump     Print the content of an entry in the archive
  extract  Extract the content of an archive
  mount    Mount an archive in a directory
  help     Print this message or the help of the given subcommand(s)

Options:
  -v, --verbose...  Set verbose level. Can be specify several times to augment verbose level
  -h, --help        Print help
  -V, --version     Print version

Advanced:
      --generate-man-page [<GENERATE_MAN_PAGE>]
          [possible values: , create, list, dump, extract, mount]
      --generate-complete <GENERATE_COMPLETE>
          [possible values: bash, elvish, fish, powershell, zsh]


$ arx --version
arx 0.2.1

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Jul 16, 2024
@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

@suzuki-shunsuke
Copy link
Member

📝 On macOS, I needed to install macFUSE.

$ arx --help
INFO[0000] download and unarchive the package            aqua_version=2.30.0-3 env=darwin/arm64 exe_name=arx package_name=jubako/arx package_version=0.2.1 program=aqua registry=standard
Downloading jubako/arx 0.2.1 100% |████████████████████████████████████████████████████████████████████████████| (2.1/2.1 MB, 28 MB/s)        
INFO[0001] downloading a checksum file                   aqua_version=2.30.0-3 env=darwin/arm64 exe_name=arx package_name=jubako/arx package_version=0.2.1 program=aqua registry=standard
dyld[24298]: Library not loaded: /usr/local/lib/libfuse.2.dylib
  Referenced from: <D50CC246-DDA5-3E78-8A5D-C588EB7C4DC1> /Users/shunsukesuzuki/.local/share/aquaproj-aqua/pkgs/github_release/github.com/jubako/arx/0.2.1/arx-0.2.1-macos.tar.gz/arx-0.2.1-macos/arx
  Reason: tried: '/usr/local/lib/libfuse.2.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/usr/local/lib/libfuse.2.dylib' (no such file), '/usr/local/lib/libfuse.2.dylib' (no such file), '/usr/lib/libfuse.2.dylib' (no such file, not in dyld cache), '/opt/homebrew/lib/libfuse.2.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/lib/libfuse.2.dylib' (no such file), '/opt/homebrew/lib/libfuse.2.dylib' (no such file), '/usr/local/lib/libfuse.2.dylib' (no such file), '/usr/lib/libfuse.2.dylib' (no such file, not in dyld cache)
zsh: abort      arx --help
brew info macfuse

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Jul 16, 2024

I don't know if you want to distribute tools which have a system dependency.

We accept tools which have dependencies, though aqua doesn't manage dependencies.

@NikitaCOEUR
Copy link
Contributor Author

How can we warn users about it ?

And I can't test on a windows operating system to check dependency too..

@suzuki-shunsuke
Copy link
Member

How can we warn users about it ?

aqua doesn't have the feature to warn users about it.
What we can do for it is to write warning in the package's description and the release note.

@suzuki-shunsuke suzuki-shunsuke added this to the v4.204.1 milestone Jul 16, 2024
@suzuki-shunsuke suzuki-shunsuke merged commit 87e8212 into aquaproj:main Jul 16, 2024
17 checks passed
@suzuki-shunsuke
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants