Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

borg: fix asset mapping rules for borg >=1.4.0 #24685

Merged
merged 5 commits into from
Jul 9, 2024
Merged

borg: fix asset mapping rules for borg >=1.4.0 #24685

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4546017
borg: fix asset mapping rules for borg >=1.4.0
reitzig Jul 8, 2024
926397b
Update registry.yaml
reitzig Jul 8, 2024
fe05896
fix(borgbackup/borg): update registry.yaml
suzuki-shunsuke Jul 9, 2024
7c2a20d
test(borgbackup/borg): add a test data
suzuki-shunsuke Jul 9, 2024
9d161e0
fix(borgbackup/borg): fix version_overrides
suzuki-shunsuke Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkgs/borgbackup/borg/registry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ packages:
supported_envs:
- linux/amd64
- darwin
- version_constraint: semver("<= 1.1.18")
- version_constraint: semver("< 1.4.0")
Copy link
Member

@suzuki-shunsuke suzuki-shunsuke Jul 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we update version_constraint, we should add test data to pkg.yaml to support old versions.

7c2a20d

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, we use <= instead of < for consistency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, we use <= instead of < for consistency.

Oh, I see.

We haven't assumed back ports, but it makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to express that given the current syntax/conventions? Could we use >= 1.4.0 and leave the 1.2.x line without constraint for the time being?

asset: borg-{{.OS}}64
format: raw
rosetta2: true
Expand All @@ -34,12 +34,12 @@ packages:
- linux/amd64
- darwin
- version_constraint: "true"
asset: borg-{{.OS}}64
asset: borg-{{.OS}}
format: raw
rosetta2: true
replacements:
amd64: x64
darwin: macos
linux: linux-glibc228
darwin: macos1012
supported_envs:
- linux/amd64
- darwin
8 changes: 4 additions & 4 deletions registry.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading