feat: add borgbackup/borg #23845
feat: add borgbackup/borg #23845
Conversation
|
FWIW: Scaffolding added a whole bunch of old versions and accompanying overrides. Instead of digging through years-old releases to fix all the overrides, I went ahead and deleted the old versions. Hope that doesn't break assumptions. 😅 |
|
🛎️ @ThomasWaldmann FYI |
|
Thank you for your contribution! |
pkgs/borgbackup/borg/pkg.yaml
Outdated
| version: 0.30.0 | ||
| - name: borgbackup/borg | ||
| version: 0.28.2 | ||
| - name: borgbackup/borg |
There was a problem hiding this comment.
aqua-registry should support not only the latest version but also old versions as much as possible.
If some versions are so old that they don't work on recent machine, we can exclude them, but otherwise we should support them as much as possible.
There was a problem hiding this comment.
FWIW: Scaffolding added a whole bunch of old versions and accompanying overrides. Instead of digging through years-old releases to fix all the overrides, I went ahead and deleted the old versions. Hope that doesn't break assumptions. 😅
Sorry. I missed your comment. I'm checking.
There was a problem hiding this comment.
Thanks for the cleanup, and sorry for the mess. 🙏
TBH, I couldn't make sense of the list of versions the scaffolding chose to include. 😅
but also old versions as much as possible
I suspect there's diminishing returns the farther back you go -- and potential security issues, too. But then, responsibility of using old versions is, ultimately, on the user.
There was a problem hiding this comment.
I suspect there's diminishing returns the farther back you go -- and potential security issues, too. But then, responsibility of using old versions is, ultimately, on the user.
Exactly. We leave the responsibility to users.
aqua-registry supports all versions as much as possible.
If we feel it's too hard to support old versions, we may give up supporting them.
|
borg worked, but was very slow even if I executed borg directly without aqua. $ aqua which borg
/Users/shunsukesuzuki/.local/share/aquaproj-aqua/pkgs/github_release/github.com/borgbackup/borg/1.1.12/borg-macosx64/borg-macosx64
$ time /Users/shunsukesuzuki/.local/share/aquaproj-aqua/pkgs/github_release/github.com/borgbackup/borg/1.1.12/borg-macosx64/borg-macosx64 --help
# ...
--help 0.28s user 0.06s system 7% cpu 4.824 total |
pkgs/borgbackup/borg/pkg.yaml
Outdated
| @@ -0,0 +1,22 @@ | |||
| packages: | |||
| - name: borgbackup/borg@1.1.12 | |||
There was a problem hiding this comment.
🤔 1.1.12 isn't latest. I'm not sure why cmdx s can't get the latest version.
There was a problem hiding this comment.
IIRC, the release API does not return releases in any particular order and you need to page. If you're already pulling all releases, I don't know.
There is a dedicated endpoint to get the latest release, so it should always be possible to get that one at least.
There was a problem hiding this comment.
By default cmdx s gets all versions and sort them by semver.
So it's weird. I'll look into this when I have time, but the priority is low.
|
|
Can confirm. I suspect that has to do with how the Python application is packaged and run:
For this application, I'm willing to take that startup overhead over having to handle globally installed pip packages. YMMV, obviously. |
|
v4.193.0 is out 🎉 |
* feat(borgbackup/borg): scaffold borgbackup/borg * fix(borgbackup/borg): Fix scaffold * Revert "fix(borgbackup/borg): Fix scaffold" This reverts commit 3730a39. * refactor(borgbackup/borg): refactor version_overrides * fix(borgbackup/borg): support latest --------- Co-authored-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
Check List
Require signed commits, so all commits must be signedAdd borgbackup/borg to the registry.
While it's also a Python package, single executables are provided by the maintainer and a supported installation method.
ref: https://borgbackup.readthedocs.io/en/1.4-maint/installation.html#pyinstaller-binary