Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Optimise the performance of getClientPertinentTenant() method by removing the isSuperUser() check #34579

Closed
NilanshBansal opened this issue Jun 28, 2024 · 2 comments
Closed

[Task]: Optimise the performance of getClientPertinentTenant() method by removing the isSuperUser() check #34579

NilanshBansal opened this issue Jun 28, 2024 · 2 comments
Assignees
@NilanshBansal
Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Task A simple Todo

Comments

@NilanshBansal
Copy link
Contributor

SubTasks

  • Remove the isSuperUser() check from all the places within the code just keep the check in /v1/tenants/current (GET).
    • For consolidated API get and edit, change the DTO from Tenant to Tenant without subscriptionDetails object which ensures we do not return this object in the consolidated APIs.
    • Check for all the other places in the code where this method is getting invoked and set the subscriptionDetails object accordingly. So, this will optimise all the other areas of code from where we are doing the isSuperUser() check unnecessarily.

Why is this Necessary?
https://www.notion.so/appsmith/Tenants-Consolidated-View-04fded2685d345f5a1b0de964d9940d4?pvs=4#d1680684684844c9a91383d4dc1a6015
@NilanshBansal NilanshBansal added Task A simple Todo Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. labels Jun 28, 2024
@NilanshBansal NilanshBansal self-assigned this Jun 28, 2024
@github-actions github-actions bot added the Integrations Product Issues related to a specific integration label Jun 28, 2024
@NilanshBansal
Copy link
Contributor Author

Added the changes in this EE PR

@NilanshBansal
Copy link
Contributor Author

This is waiting for the past 4 days on the instrumentation PRs #34516 and https://github.com/appsmithorg/appsmith-ee/pull/4539 to be in production, as we can view some metrics and then do this optimisation.
Unfortunately, the promotion is failing every day.
https://theappsmith.slack.com/archives/C02GAUE9P5H/p1719926433808089?thread_ts=1719909864.823359&cid=C02GAUE9P5H

@Nikhil-Nandagopal Nikhil-Nandagopal added the Query & JS Pod Issues related to the query & JS Pod label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NilanshBansal NilanshBansal

Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Nikhil-Nandagopal @NilanshBansal @rohan-arthur