Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sending notifications does not work via gRPC, got context canceled error, latest version? #790

Closed
arllen133 opened this issue Jun 28, 2024 · 4 comments · Fixed by #798
Closed

sending notifications does not work via gRPC, got context canceled error, latest version? #790

arllen133 opened this issue Jun 28, 2024 · 4 comments · Fixed by #798

Comments

@arllen133
Copy link 

	go func() {
		_, err := notify.SendNotification(ctx, &notification, s.cfg)
		if err != nil {
			logx.LogError.Error(err)
		}
	}()

ctx will canceled when rpc request return, cause goroutine finished
@appleboy
Copy link
Owner

I will take it.

@supersida159
Copy link

i have same issue so should i downgrade version ?

@arllen133
Copy link
Author

i have same issue so should i downgrade version ?

yes, or fork and fixed it

@appleboy
Copy link
Owner

I will test it asap.

@appleboy appleboy mentioned this issue Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(gRPC): create new context to avoid context cancel appleboy/gorush
3 participants
@appleboy @supersida159 @arllen133