diff --git a/bin/catalina.bat b/bin/catalina.bat index 635093285238..e2e1c4ac8da3 100755 --- a/bin/catalina.bat +++ b/bin/catalina.bat @@ -89,11 +89,11 @@ rem "-Djdk.tls.ephemeralDHKeySize=2048" rem rem CATALINA_LOGGING_CONFIG (Optional) Override Tomcat's logging config file rem Example (all one line) -rem set CATALINA_LOGGING_CONFIG="-Djava.util.logging.config.file=%CATALINA_BASE%\conf\logging.properties" +rem set CATALINA_LOGGING_CONFIG=-Djava.util.logging.config.file="%CATALINA_BASE%\conf\logging.properties" rem rem LOGGING_MANAGER (Optional) Override Tomcat's logging manager rem Example (all one line) -rem set LOGGING_MANAGER="-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager" +rem set LOGGING_MANAGER=-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager rem rem TITLE (Optional) Specify the title of Tomcat window. The default rem TITLE is Tomcat if it's not specified. @@ -234,7 +234,7 @@ echo Using JAVA_HOME: "%JAVA_HOME%" echo Using CLASSPATH: "%CLASSPATH%" echo Using CATALINA_OPTS: "%CATALINA_OPTS%" -set _EXECJAVA=%_RUNJAVA% +set _EXECJAVA="%_RUNJAVA%" set MAINCLASS=org.apache.catalina.startup.Bootstrap set ACTION=start set DEBUG_OPTS= @@ -277,7 +277,7 @@ goto end :doDebug shift -set _EXECJAVA=%_RUNJDB% +set _EXECJAVA="%_RUNJDB%" set DEBUG_OPTS=-sourcepath "%CATALINA_HOME%\..\..\java" goto execCmd @@ -288,7 +288,7 @@ goto execCmd :doStart shift if "%TITLE%" == "" set TITLE=Tomcat -set _EXECJAVA=start "%TITLE%" %_RUNJAVA% +set _EXECJAVA=start "%TITLE%" "%_RUNJAVA%" goto execCmd :doStop diff --git a/bin/setclasspath.bat b/bin/setclasspath.bat index 62e5d70cb3c0..ded6ac13b6c4 100755 --- a/bin/setclasspath.bat +++ b/bin/setclasspath.bat @@ -77,13 +77,13 @@ rem Don't override _RUNJAVA if the user has set it previously if not "%_RUNJAVA%" == "" goto gotRunJava rem Set standard command for invoking Java. rem Also note the quoting as JRE_HOME may contain spaces. -set _RUNJAVA="%JRE_HOME%\bin\java.exe" +set "_RUNJAVA=%JRE_HOME%\bin\java.exe" :gotRunJava rem Don't override _RUNJDB if the user has set it previously rem Also note the quoting as JAVA_HOME may contain spaces. if not "%_RUNJDB%" == "" goto gotRunJdb -set _RUNJDB="%JAVA_HOME%\bin\jdb.exe" +set "_RUNJDB=%JAVA_HOME%\bin\jdb.exe" :gotRunJdb goto end diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 620ee71966b8..2358221c9fc8 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -190,6 +190,11 @@ Improvements to Japanese translations. Contributed by tak7iji and Shirayuking. (markt) + + 66829: Fix quoting so users can use the _RUNJAVA + environment variable as intended on Windows when the path to the Java + executable contains spaces. (markt) +