From cb1c5530fadf7a6315181a9333a13decc00485a6 Mon Sep 17 00:00:00 2001 From: Lai Wei Date: Thu, 2 Aug 2018 17:55:33 -0700 Subject: [PATCH 1/3] fix test bind, remove fixed seed --- tests/python/unittest/test_executor.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/python/unittest/test_executor.py b/tests/python/unittest/test_executor.py index 3117f6646481..2bc696fd4e43 100644 --- a/tests/python/unittest/test_executor.py +++ b/tests/python/unittest/test_executor.py @@ -72,7 +72,7 @@ def check_bind_with_uniform(uf, gf, dim, sf=None, lshape=None, rshape=None): assert_almost_equal(rhs_grad.asnumpy(), rhs_grad2, rtol=1e-5, atol=1e-5) -@with_seed(0) +@with_seed() def test_bind(): def check_bind(disable_bulk_exec): if disable_bulk_exec: @@ -97,11 +97,11 @@ def check_bind(disable_bulk_exec): dim) check_bind_with_uniform(lambda x, y: np.maximum(x, y), - lambda g, x, y: (g * (x>y), g * (y>x)), + lambda g, x, y: (g * (x>=y), g * (y>x)), dim, sf=mx.symbol.maximum) check_bind_with_uniform(lambda x, y: np.minimum(x, y), - lambda g, x, y: (g * (x Date: Thu, 2 Aug 2018 18:14:57 -0700 Subject: [PATCH 2/3] add tracking info --- tests/python/unittest/test_executor.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/python/unittest/test_executor.py b/tests/python/unittest/test_executor.py index 2bc696fd4e43..8227e34eb43d 100644 --- a/tests/python/unittest/test_executor.py +++ b/tests/python/unittest/test_executor.py @@ -72,6 +72,8 @@ def check_bind_with_uniform(uf, gf, dim, sf=None, lshape=None, rshape=None): assert_almost_equal(rhs_grad.asnumpy(), rhs_grad2, rtol=1e-5, atol=1e-5) +# @roywei: Removing fixed seed as flakiness in this test is fixed +# tracked at: https://github.com/apache/incubator-mxnet/issues/11685 @with_seed() def test_bind(): def check_bind(disable_bulk_exec): From 50803afeb1c290c0c09af5f4746ecb34511e9694 Mon Sep 17 00:00:00 2001 From: Lai Wei Date: Sat, 4 Aug 2018 12:03:48 -0700 Subject: [PATCH 3/3] remove tracking info --- tests/python/unittest/test_executor.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/python/unittest/test_executor.py b/tests/python/unittest/test_executor.py index 8227e34eb43d..2bc696fd4e43 100644 --- a/tests/python/unittest/test_executor.py +++ b/tests/python/unittest/test_executor.py @@ -72,8 +72,6 @@ def check_bind_with_uniform(uf, gf, dim, sf=None, lshape=None, rshape=None): assert_almost_equal(rhs_grad.asnumpy(), rhs_grad2, rtol=1e-5, atol=1e-5) -# @roywei: Removing fixed seed as flakiness in this test is fixed -# tracked at: https://github.com/apache/incubator-mxnet/issues/11685 @with_seed() def test_bind(): def check_bind(disable_bulk_exec):