This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic Library Loading Support #15489
Dynamic Library Loading Support #15489
Changes from all commits
a48210e
63958da
5f9d6fa
4f9a021
d519695
602a372
565dbd2
3dc7832
001bbb1
3e93d81
35913da
87fa3cf
0dad266
16afd96
f265d04
955cf98
7d3d530
3e846c4
bc4cbd2
53e71df
db84009
25a9ccb
1682af3
7551313
68a4e6c
e8c8d2f
71ac937
4cb4caf
4e2dba8
7f8a9fb
672b2b9
2257ff3
0d05d1c
3879f61
289c3a5
a3b545d
e512d64
134cc37
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it have to be an absolute path? Can we clarify? What if the library is installed in /usr/lib?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dynamic loader (dlopen) requires the path to be absolute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So can't we make it absolute programmatically in a Python level as a convenience for the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion @ptrendx. We thought about this. We could, but if the user passes in "./libmyacc.so" and Python is running in a different dir, we're going to make the wrong absolute path "/user/home/libmyacc.so".
So initially we were thinking that it just makes more sense to require the user to provide that as input. It would avoid confusion around "how is this path getting created".