Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async optimization. #3287

Closed
chickenlj opened this issue Jan 21, 2019 · 8 comments
Closed

Async optimization. #3287

chickenlj opened this issue Jan 21, 2019 · 8 comments
Assignees
Milestone

Comments

@chickenlj
Copy link
Contributor

@chickenlj chickenlj added this to the 2.7.1 milestone Jan 21, 2019
@chickenlj chickenlj self-assigned this Mar 5, 2019
@cvictory cvictory modified the milestones: 2.7.1, 2.7.2 Mar 14, 2019
@chickenlj
Copy link
Contributor Author

chickenlj commented Mar 14, 2019

Generic support, #3637, done
Filters, #3483, almost done
Attachments, #3620, done
Zipkin, #3576, done, nothing to fix
Provider async, #3650, need to remove async config item.

@carryxyh
Copy link
Member

carryxyh commented Mar 18, 2019

Just for a record:
Maybe we should consider the case when C and P use asynchronous at the same time. Currently, when the interface returns a value of CompletableFuture and uses AsyncContext to start asynchronous in ServiceImpl, it will cause some problems.

@maxiaoguang64
Copy link
Contributor

yes, but we can't know that consumer use async

@carryxyh
Copy link
Member

Nope, currently Dubbo's consumer asynchronous depends on the server configuration, so we can of course know if the client is using asynchronous...

@maxiaoguang64
Copy link
Contributor

if user use like this
new Thread(() -> service.method()).start()?

@carryxyh
Copy link
Member

In this case, the dubbo framework is treated as a synchronous call. This will not cause any problems.
:)

@maxiaoguang64
Copy link
Contributor

image
in this picture, i use new Thread(() -> service.method()).start() and service is async

@carryxyh
Copy link
Member

carryxyh commented Mar 19, 2019

I don't know the content on this picture. This issue was created to discuss the problem of asynchronous methods in the dubbo framework(Or asynchronous in the dubbo kernel).

My records are not the same problem as the scene you describe. If there are other problems with dubbo's asynchronous, you should create a complete issue to describe it. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants