From 715adddd69938f01df8fac8340a7f44d4072297b Mon Sep 17 00:00:00 2001 From: Vadim Ogievetsky Date: Mon, 4 Dec 2023 12:03:48 -0800 Subject: [PATCH 1/2] log out e2e responce errors --- web-console/e2e-tests/auto-compaction.spec.ts | 2 +- web-console/e2e-tests/reindexing.spec.ts | 2 +- web-console/e2e-tests/tutorial-batch.spec.ts | 2 +- web-console/e2e-tests/util/playwright.ts | 15 +++++++++++++-- 4 files changed, 16 insertions(+), 5 deletions(-) diff --git a/web-console/e2e-tests/auto-compaction.spec.ts b/web-console/e2e-tests/auto-compaction.spec.ts index 58aa047d03dd..cfdaa9dd520f 100644 --- a/web-console/e2e-tests/auto-compaction.spec.ts +++ b/web-console/e2e-tests/auto-compaction.spec.ts @@ -55,7 +55,7 @@ describe('Auto-compaction', () => { }); it('Compacts segments from dynamic to hash partitions', async () => { - const testName = 'autocompaction-dynamic-to-hash-'; + const testName = 'autocompaction-dynamic-to-hash'; const datasourceName = testName + new Date().toISOString(); loadInitialData(datasourceName); diff --git a/web-console/e2e-tests/reindexing.spec.ts b/web-console/e2e-tests/reindexing.spec.ts index 65a1e1209748..a0a8e710d912 100644 --- a/web-console/e2e-tests/reindexing.spec.ts +++ b/web-console/e2e-tests/reindexing.spec.ts @@ -60,7 +60,7 @@ describe('Reindexing from Druid', () => { }); it('Reindex datasource from dynamic to range partitions', async () => { - const testName = 'reindex-dynamic-to-range-'; + const testName = 'reindex-dynamic-to-range'; const datasourceName = testName + new Date().toISOString(); const interval = '2015-09-12/2015-09-13'; const dataConnector = new ReindexDataConnector(page, { diff --git a/web-console/e2e-tests/tutorial-batch.spec.ts b/web-console/e2e-tests/tutorial-batch.spec.ts index 4b4d90e200b8..3fa15af9d2a4 100644 --- a/web-console/e2e-tests/tutorial-batch.spec.ts +++ b/web-console/e2e-tests/tutorial-batch.spec.ts @@ -56,7 +56,7 @@ describe('Tutorial: Loading a file', () => { }); it('Loads data from local disk', async () => { - const testName = 'load-data-from-local-disk-'; + const testName = 'load-data-from-local-disk'; const datasourceName = testName + ALL_SORTS_OF_CHARS + new Date().toISOString(); const dataLoader = new DataLoader({ page: page, diff --git a/web-console/e2e-tests/util/playwright.ts b/web-console/e2e-tests/util/playwright.ts index 6c838ca2a491..95fef3e065df 100644 --- a/web-console/e2e-tests/util/playwright.ts +++ b/web-console/e2e-tests/util/playwright.ts @@ -19,8 +19,8 @@ import * as playwright from 'playwright-chromium'; const TRUE = 'true'; -const WIDTH = 1920; -const HEIGHT = 1080; +const WIDTH = 1250; +const HEIGHT = 760; const PADDING = 128; export async function createBrowser(): Promise { @@ -40,6 +40,17 @@ export async function createPage(browser: playwright.Browser): Promise { + if (response.status() < 400) return; + const request = response.request(); + console.log(`==============================================`); + console.log(`Request failed on ${request.url()} (with status ${response.status()})`); + console.log(`Body: ${await response.text()}`); + console.log(`==============================================`); + }); + return page; } From 5979545ccacccb1cf26656eb263340856b77d0b8 Mon Sep 17 00:00:00 2001 From: Vadim Ogievetsky Date: Mon, 4 Dec 2023 13:02:10 -0800 Subject: [PATCH 2/2] log all together --- web-console/e2e-tests/util/playwright.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/web-console/e2e-tests/util/playwright.ts b/web-console/e2e-tests/util/playwright.ts index 95fef3e065df..ed5fb01b6dff 100644 --- a/web-console/e2e-tests/util/playwright.ts +++ b/web-console/e2e-tests/util/playwright.ts @@ -44,10 +44,18 @@ export async function createPage(browser: playwright.Browser): Promise { if (response.status() < 400) return; + const request = response.request(); + let bodyText: string; + try { + bodyText = await response.text(); + } catch (e) { + bodyText = `Could not get the body of the error message due to: ${e.message}`; + } + console.log(`==============================================`); console.log(`Request failed on ${request.url()} (with status ${response.status()})`); - console.log(`Body: ${await response.text()}`); + console.log(`Body: ${bodyText}`); console.log(`==============================================`); });